From: Laurence Oberman <loberman@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org,
emilne@redhat.com, djeffery@redhat.com, apanagio@redhat.com,
torez@redhat.com
Subject: Re: [PATCH] usb: hcd: Revert 306c54d0edb6ba94d39877524dddebaad7770cf2: Try MSI interrupts on PCI devices
Date: Tue, 13 Jul 2021 17:57:49 -0400 [thread overview]
Message-ID: <b8ed5382e6162fbc8639002cdeffec3007ead5dd.camel@redhat.com> (raw)
In-Reply-To: <YO34tyvp/hkO+24F@smile.fi.intel.com>
On Tue, 2021-07-13 at 23:33 +0300, Andy Shevchenko wrote:
> On Tue, Jul 13, 2021 at 02:50:42PM -0400, Laurence Oberman wrote:
> > Customers have been reporting that the I/O is radically being
> > slowed down to HPE virtual USB ILO served DVD images during
> > installation.
>
> Side note:
>
> Simple changing
>
> - retval = pci_alloc_irq_vectors(dev, 1, 1,
> PCI_IRQ_LEGACY | PCI_IRQ_MSI);
> + retval = pci_alloc_irq_vectors(dev, 1, 1,
> PCI_IRQ_LEGACY);
>
> should have the same effect without touching tons of a good code.
>
Andy and Alan,
I tested this and as expected it worked as well.
However David has given me a possible ehci fix which would be the best
outcome you wanted, I am testing that now and will follow up tomorrow.
Regards
Laurence
next prev parent reply other threads:[~2021-07-13 21:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 18:50 [PATCH] usb: hcd: Revert 306c54d0edb6ba94d39877524dddebaad7770cf2: Try MSI interrupts on PCI devices Laurence Oberman
2021-07-13 19:15 ` Alan Stern
2021-07-13 20:05 ` Laurence Oberman
2021-07-13 20:30 ` Andy Shevchenko
2021-07-13 20:30 ` kernel test robot
2021-07-13 20:33 ` Andy Shevchenko
2021-07-13 20:44 ` Laurence Oberman
2021-07-13 21:57 ` Laurence Oberman [this message]
2021-07-13 23:11 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8ed5382e6162fbc8639002cdeffec3007ead5dd.camel@redhat.com \
--to=loberman@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=apanagio@redhat.com \
--cc=djeffery@redhat.com \
--cc=emilne@redhat.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torez@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox