From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA9EEC11F66 for ; Tue, 13 Jul 2021 21:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DDF061175 for ; Tue, 13 Jul 2021 21:57:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235821AbhGMWAo (ORCPT ); Tue, 13 Jul 2021 18:00:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21095 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235756AbhGMWAn (ORCPT ); Tue, 13 Jul 2021 18:00:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626213472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9NqpBaF//aj2A9EcG9Kn7g2tzsF0+GouVQxjJctCg8k=; b=ETyd8lO5eTylz+e8BB3Unvu6MinloT+8gNRzkzLMdXjTJ7tpzVDWHlbIk2OFLP/FXw23CI 2vLvZIuGhvlnXeBC7Q4lq4LnvbRHTf51DTIQvogGX6fIXX1r5dFDDCSxyilEq9+YG919xz wpuSySVOqR6w9O+c9o5k2PRQGm8fLFc= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-JN2sdXFLNHqc1gh8zXzoFw-1; Tue, 13 Jul 2021 17:57:51 -0400 X-MC-Unique: JN2sdXFLNHqc1gh8zXzoFw-1 Received: by mail-qk1-f199.google.com with SMTP id w16-20020a05620a4450b02903b88832b7cfso4160038qkp.5 for ; Tue, 13 Jul 2021 14:57:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=9NqpBaF//aj2A9EcG9Kn7g2tzsF0+GouVQxjJctCg8k=; b=SyGWfJsBq6e1W75UqZyxHgVzD3A0AE3cd7PNBzBeU01wukxueIN3cyu8SKDknlFd7R wfXb/w3HwfRNDhyfmfp/B6vh6rGvRJl90chCRHt39gVEE6ceKi1tIUYTy+KJvZC01vSn cim7RBy+zWzVKtExSG8hBw7dQQMeG4EBSPRPFriYH/tRN38bBC3b5AMo9PwPKP3LyyWB GApb5/VYEgiNTUlvFC2zmC2vMVB3J+WT1JMKiOJ8aKLKK6WhMP9MsbgRc8QRy8t+295F w7V2oadP73Z9xLQ/2adXL3B+36V/a2H9nmqc2+pQgJIlvARLxzc83AQ4Cud87xRWmV3z TBTA== X-Gm-Message-State: AOAM533s1NDv7hH8FcZQu+9O06cJyxxK4OwEnXtg7OADJGu0nPypHn1g gzcMxxV434+qxiSaMgjo6GA8DWbW5NjHc1/BR5Hprmp92PzdB/lVz/uJ2UtTFR7nJnTd7U989Vk h/grXLrOcJMx6L9F0HEVk X-Received: by 2002:a0c:a997:: with SMTP id a23mr7246722qvb.48.1626213470877; Tue, 13 Jul 2021 14:57:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCT4xi3IffBENgN1FcPchFBX/OcsAOPopINVu0g0LXVH6ZButpHKZ/v5QNj//JjJPmr4qvEw== X-Received: by 2002:a0c:a997:: with SMTP id a23mr7246710qvb.48.1626213470679; Tue, 13 Jul 2021 14:57:50 -0700 (PDT) Received: from loberhel ([2600:6c64:4e7f:cee0:729d:61b6:700c:6b56]) by smtp.gmail.com with ESMTPSA id y26sm98439qkm.32.2021.07.13.14.57.49 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jul 2021 14:57:50 -0700 (PDT) Message-ID: Subject: Re: [PATCH] usb: hcd: Revert 306c54d0edb6ba94d39877524dddebaad7770cf2: Try MSI interrupts on PCI devices From: Laurence Oberman To: Andy Shevchenko Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org, emilne@redhat.com, djeffery@redhat.com, apanagio@redhat.com, torez@redhat.com Date: Tue, 13 Jul 2021 17:57:49 -0400 In-Reply-To: References: <1626202242-14984-1-git-send-email-loberman@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, 2021-07-13 at 23:33 +0300, Andy Shevchenko wrote: > On Tue, Jul 13, 2021 at 02:50:42PM -0400, Laurence Oberman wrote: > > Customers have been reporting that the I/O is radically being > > slowed down to HPE virtual USB ILO served DVD images during > > installation. > > Side note: > > Simple changing > > - retval = pci_alloc_irq_vectors(dev, 1, 1, > PCI_IRQ_LEGACY | PCI_IRQ_MSI); > + retval = pci_alloc_irq_vectors(dev, 1, 1, > PCI_IRQ_LEGACY); > > should have the same effect without touching tons of a good code. > Andy and Alan, I tested this and as expected it worked as well. However David has given me a possible ehci fix which would be the best outcome you wanted, I am testing that now and will follow up tomorrow. Regards Laurence