From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AECA7497 for ; Sat, 4 Nov 2023 08:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eHNWUtqx" Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F65B19D; Sat, 4 Nov 2023 01:01:48 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-32f7bd27c2aso1928448f8f.2; Sat, 04 Nov 2023 01:01:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699084906; x=1699689706; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hS3Le+HbToOOqCmf/VLmbjpEkM0sZUVHEoDgdyjma5k=; b=eHNWUtqxZDdyOwKFG8QTEUS3cweGgffbvri7HNraW63+OByRwEyUvdWnhNE/siCAl1 0KL9vKwgoHV4/11aLKfuIvFnV6F2GT02ELYCS+To9dCM3XI1GaT3tQO3hxxpximApT3y I2GGRqlcHrGZG80CvwVoHqZuzpMWUm0jXdaZ8kMh4lnLyu6xrjdWl5EeaXkxnSGWaqxh nq94Byz5LVbvNFYVUoNOkX1Y4Af6+JOgKIMwVv0s3iTdB4Bx6mVU8OP/WpKxaNQNZQFZ 1+9g4zAFiF7SjcY2oPz3Zzox9uqx2wTH1T+M7nwo6Hrd1jKb7YJbXh7BM3EaQu0AdhEa GGXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699084906; x=1699689706; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hS3Le+HbToOOqCmf/VLmbjpEkM0sZUVHEoDgdyjma5k=; b=V31G4Go/BGcC5UR8kZ5naY9Ee/ZBHNqN5geIS9VdO7wxT+8vi/OIQW2vgfw+W3acJA hhpT5xbFbupqBpI+UoAt0Gqd0w1kNGBDvmU5/4dOT6g33+xYjxYOgiO8J1Z/zy1ui5pF gWeGNvGCz0YundwIDftl2GQFurO8T3VIPBeyz7nCEkjV7P+7+EMe0bTnQavS1NMd+dcp Lknav4h7zrSuxsfLBnPqFDSL2RqgtbFrc5AQxxHxl0i8W0E9CnsoZVi3+OlgMVff49JP XpugE2muqPq+xtxeMjlcSFIrXH500UukdMzowhQYtoJ2eZyCZEI9vBgFzxtZj0cn5ja+ NMHA== X-Gm-Message-State: AOJu0YwOx95xFP552EsZCdDNrnl/0rPGE9yGSLiyJHjdgBgfuI1RQkeU TMgHmLMyNUDWopVXjZ+mqHw= X-Google-Smtp-Source: AGHT+IGdVfS2CvoSckI0P8OyIN3WvS8hnw2CSGVUfb9ZAVe4UHlFUw+L9clUOEa/KZtQJSoiR9qE/A== X-Received: by 2002:adf:d1c9:0:b0:32d:8505:b9d7 with SMTP id b9-20020adfd1c9000000b0032d8505b9d7mr19906302wrd.43.1699084906348; Sat, 04 Nov 2023 01:01:46 -0700 (PDT) Received: from [192.168.2.31] (85-70-151-113.rcd.o2.cz. [85.70.151.113]) by smtp.gmail.com with ESMTPSA id k17-20020a5d6e91000000b0032d9382e6e0sm3724244wrz.45.2023.11.04.01.01.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Nov 2023 01:01:45 -0700 (PDT) Message-ID: Date: Sat, 4 Nov 2023 09:01:44 +0100 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] usb-storage,uas: use host helper to generate driver info Content-Language: en-US To: Alan Stern Cc: linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, linux-scsi@vger.kernel.org, gregkh@linuxfoundation.org, oneukum@suse.com References: <20231028174145.691523-1-gmazyland@gmail.com> <20231103201709.124372-1-gmazyland@gmail.com> From: Milan Broz Autocrypt: addr=gmazyland@gmail.com; keydata= xsFNBE94p38BEADZRET8y1gVxlfDk44/XwBbFjC7eM6EanyCuivUPMmPwYDo9qRey0JdOGhW hAZeutGGxsKliozmeTL25Z6wWICu2oeY+ZfbgJQYHFeQ01NVwoYy57hhytZw/6IMLFRcIaWS Hd7oNdneQg6mVJcGdA/BOX68uo3RKSHj6Q8GoQ54F/NpCotzVcP1ORpVJ5ptyG0x6OZm5Esn 61pKE979wcHsz7EzcDYl+3MS63gZm+O3D1u80bUMmBUlxyEiC5jo5ksTFheA8m/5CAPQtxzY vgezYlLLS3nkxaq2ERK5DhvMv0NktXSutfWQsOI5WLjG7UWStwAnO2W+CVZLcnZV0K6OKDaF bCj4ovg5HV0FyQZknN2O5QbxesNlNWkMOJAnnX6c/zowO7jq8GCpa3oJl3xxmwFbCZtH4z3f EVw0wAFc2JlnufR4dhaax9fhNoUJ4OSVTi9zqstxhEyywkazakEvAYwOlC5+1FKoc9UIvApA GvgcTJGTOp7MuHptHGwWvGZEaJqcsqoy7rsYPxtDQ7bJuJJblzGIUxWAl8qsUsF8M4ISxBkf fcUYiR0wh1luUhXFo2rRTKT+Ic/nJDE66Ee4Ecn9+BPlNODhlEG1vk62rhiYSnyzy5MAUhUl stDxuEjYK+NGd2aYH0VANZalqlUZFTEdOdA6NYROxkYZVsVtXQARAQABzSBNaWxhbiBCcm96 IDxnbWF6eWxhbmRAZ21haWwuY29tPsLBlQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AWIQQqKRgkP95GZI0GhvnZsFd72T6Y/AUCYaUUZgUJJPhv5wAKCRDZsFd72T6Y/D5N D/438pkYd5NyycQ2Gu8YAjF57Od2GfeiftCDBOMXzh1XxIx7gLosLHvzCZ0SaRYPVF/Nr/X9 sreJVrMkwd1ILNdCQB1rLBhhKzwYFztmOYvdCG9LRrBVJPgtaYqO/0493CzXwQ7FfkEc4OVB uhBs4YwFu+kmhh0NngcP4jaaaIziHw/rQ9vLiAi28p1WeVTzOjtBt8QisTidS2VkZ+/iAgqB 9zz2UPkE1UXBAPU4iEsGCVXGWRz99IULsTNjP4K3p8ZpdZ6ovy7X6EN3lYhbpmXYLzZ3RXst PEojSvqpkSQsjUksR5VBE0GnaY4B8ZlM3Ng2o7vcxbToQOsOkbVGn+59rpBKgiRadRFuT+2D x80VrwWBccaph+VOfll9/4FVv+SBQ1wSPOUHl11TWVpdMFKtQgA5/HHldVqrcEssWJb9/tew 9pqxTDn6RHV/pfzKCspiiLVkI66BF802cpyboLBBSvcDuLHbOBHrpC+IXCZ7mgkCrgMlZMql wFWBjAu8Zlc5tQJPgE9eeQAQrfZRcLgux88PtxhVihA1OsMNoqYapgMzMTubLUMYCCsjrHZe nzw5uTcjig0RHz9ilMJlvVbhwVVLmmmf4p/R37QYaqm1RycLpvkUZUzSz2NCyTcZp9nM6ooR GhpDQWmUdH1Jz9T6E9//KIhI6xt4//P15ZfiIs7BTQRPeKd/ARAA3oR1fJ/D3GvnoInVqydD U9LGnMQaVSwQe+fjBy5/ILwo3pUZSVHdaKeVoa84gLO9g6JLToTo+ooMSBtsCkGHb//oiGTU 7KdLTLiFh6kmL6my11eiK53o1BI1CVwWMJ8jxbMBPet6exUubBzceBFbmqq3lVz4RZ2D1zKV njxB0/KjdbI53anIv7Ko1k+MwaKMTzO/O6vBmI71oGQkKO6WpcyzVjLIip9PEpDUYJRCrhKg hBeMPwe+AntP9Om4N/3AWF6icarGImnFvTYswR2Q+C6AoiAbqI4WmXOuzJLKiImwZrSYnSfQ 7qtdDGXWYr/N1+C+bgI8O6NuAg2cjFHE96xwJVhyaMzyROUZgm4qngaBvBvCQIhKzit61oBe I/drZ/d5JolzlKdZZrcmofmiCQRa+57OM3Fbl8ykFazN1ASyCex2UrftX5oHmhaeeRlGVaTV iEbAvU4PP4RnNKwaWQivsFhqQrfFFhvFV9CRSvsR6qu5eiFI6c8CjB49gBcKKAJ9a8gkyWs8 sg4PYY7L15XdRn8kOf/tg98UCM1vSBV2moEJA0f98/Z48LQXNb7dgvVRtH6owARspsV6nJyD vktsLTyMW5BW9q4NC1rgQC8GQXjrQ+iyQLNwy5ESe2MzGKkHogxKg4Pvi1wZh9Snr+RyB0Rq rIrzbXhyi47+7wcAEQEAAcLBfAQYAQgAJgIbDBYhBCopGCQ/3kZkjQaG+dmwV3vZPpj8BQJh pRSXBQkk+HAYAAoJENmwV3vZPpj8BPMP/iZV+XROOhs/MsKd7ngQeFgETkmt8YVhb2Rg3Vgp AQe9cn6aw9jk3CnB0ecNBdoyyt33t3vGNau6iCwlRfaTdXg9qtIyctuCQSewY2YMk5AS8Mmb XoGvjH1Z/irrVsoSz+N7HFPKIlAy8D/aRwS1CHm9saPQiGoeR/zThciVYncRG/U9J6sV8XH9 OEPnQQR4w/V1bYI9Sk+suGcSFN7pMRMsSslOma429A3bEbZ7Ikt9WTJnUY9XfL5ZqQnjLeRl 8243OTfuHSth26upjZIQ2esccZMYpQg0/MOlHvuFuFu6MFL/gZDNzH8jAcBrNd/6ABKsecYT nBInKH2TONc0kC65oAhrSSBNLudTuPHce/YBCsUCAEMwgJTybdpMQh9NkS68WxQtXxU6neoQ U7kEJGGFsc7/yXiQXuVvJUkK/Xs04X6j0l1f/6KLoNQ9ep/2In596B0BcvvaKv7gdDt1Trgg vlB+GpT+iFRLvhCBe5kAERREfRfmWJq1bHod/ulrp/VLGAaZlOBTgsCzufWF5SOLbZkmV2b5 xy2F/AU3oQUZncCvFMTWpBC+gO/o3kZCyyGCaQdQe4jS/FUJqR1suVwNMzcOJOP/LMQwujE/ Ch7XLM35VICo9qqhih4OvLHUAWzC5dNSipL+rSGHvWBdfXDhbezJIl6sp7/1rJfS8qPs In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/3/23 21:30, Alan Stern wrote: > On Fri, Nov 03, 2023 at 09:17:09PM +0100, Milan Broz wrote: >> The USB mass storage quirks flags can be stored in driver_info in >> a 32-bit integer (unsigned long on 32-bit platforms). >> As this attribute cannot be enlarged, we need to use some form >> of translation of 64-bit quirk bits. >> >> This problem was discussed on the USB list >> https://lore.kernel.org/linux-usb/f9e8acb5-32d5-4a30-859f-d4336a86b31a@gmail.com/ >> >> The initial solution to use a static array extensively increased the size >> of the kernel module, so I decided to try the second suggested solution: >> generate a table by host-compiled program and use bit 31 to indicate >> that the value is an index, not the actual value. >> >> This patch adds a host-compiled program that processes unusual_devs.h >> (and unusual_uas.h) and generates files usb-ids.c and usb-ids-uas.c >> (for pre-processed USB device table with 32-bit device info). >> These files also contain a generated translation table for driver_info >> to 64-bit values. >> >> The translation function is used only in usb-storage and uas modules; all >> other USB storage modules store flags directly, using only 32-bit flags. >> >> For 64-bit platforms, where unsigned long is 64-bit, we do not need to >> convert quirk flags to 32-bit index; the translation function there uses >> flags directly. >> >> Signed-off-by: Milan Broz >> --- > > Reviewed-by: Alan Stern Thanks. Unfortunately, the build rules, I removed in this version, are needed, see https://lore.kernel.org/oe-kbuild-all/202311041507.AOYwj5tK-lkp@intel.com/ I'll keep fixed version in my branch on kernel.org for a day and once there are no such bot reports, new version v6 appears in the list. Thanks, Milan