From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jonathan Marek <jonathan@marek.ca>, linux-arm-msm@vger.kernel.org
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Caleb Connolly <caleb.connolly@linaro.org>,
Guenter Roeck <linux@roeck-us.net>,
"open list:QUALCOMM TYPEC PORT MANAGER DRIVER"
<linux-usb@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF
Date: Sun, 6 Oct 2024 12:21:17 +0100 [thread overview]
Message-ID: <b9e1c0ae-5651-418a-9b71-897cd739ed0c@linaro.org> (raw)
In-Reply-To: <20241005144146.2345-1-jonathan@marek.ca>
On 05/10/2024 15:41, Jonathan Marek wrote:
> This line is overwriting the result of the above switch-case.
>
> This fixes the tcpm driver getting stuck in a "Sink TX No Go" loop.
>
> Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver")
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> index a747baa297849..c37dede62e12c 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -432,7 +432,6 @@ static int qcom_pmic_typec_port_get_cc(struct tcpc_dev *tcpc,
> val = TYPEC_CC_RP_DEF;
> break;
> }
> - val = TYPEC_CC_RP_DEF;
> }
>
> if (misc & CC_ORIENTATION)
Acked-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2024-10-06 11:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 14:41 [PATCH] usb: typec: qcom-pmic-typec: fix sink status being overwritten with RP_DEF Jonathan Marek
2024-10-06 11:21 ` Bryan O'Donoghue [this message]
2024-10-06 15:41 ` Dmitry Baryshkov
2024-10-09 8:32 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e1c0ae-5651-418a-9b71-897cd739ed0c@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=caleb.connolly@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox