From: Florian Faber <faber@faberman.de>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: core: Fix possible memleak in usb_add_gadget
Date: Sun, 5 Sep 2021 21:58:57 +0200 [thread overview]
Message-ID: <ba414322-f2fa-ed2c-c5c3-1dfeb2b71688@faberman.de> (raw)
In-Reply-To: <YTTv6u2FXTJFrSFx@kroah.com>
On 9/5/21 6:27 PM, Greg KH wrote:
> On Sun, Sep 05, 2021 at 05:16:36PM +0200, Florian Faber wrote:
>> This 'leak' was found by Klocwork and seemed plausible at first oversight.
>> Sorry for wasting your time and not checking it further.
>
> What is "Klockwork"?
Some static code analysis tool. I did not know it either.
> How can it miss the reference counted logic that
> all drivers use in the kernel?
Obviously it is not running like clockwork :)
Anyway, got the problem fixed, sorry for the noise.
Flo
--
Machines can do the work, so people have time to think.
prev parent reply other threads:[~2021-09-05 20:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 15:34 [PATCH] usb: core: Fix possible memleak in usb_add_gadget Florian Faber
2021-09-04 16:12 ` Alan Stern
2021-09-05 14:56 ` Greg KH
2021-09-05 15:16 ` Florian Faber
2021-09-05 16:27 ` Greg KH
2021-09-05 19:58 ` Florian Faber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba414322-f2fa-ed2c-c5c3-1dfeb2b71688@faberman.de \
--to=faber@faberman.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox