From: Hayes Wang <hayeswang@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Limonciello, Mario" <mario.limonciello@amd.com>,
"edumazet@google.com" <edumazet@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"Paul Menzel" <pmenzel@molgen.mpg.de>
Subject: RE: Error 'netif_napi_add_weight() called with weight 256'
Date: Wed, 9 Aug 2023 13:11:57 +0000 [thread overview]
Message-ID: <ba9b777754f7493ba14faa2dab7d8d59@realtek.com> (raw)
In-Reply-To: <20230807093727.5249f517@kernel.org>
Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, August 8, 2023 12:37 AM
[...]
> > I test our devices on an Embedded system.
> > We find the throughput is low.
> > And it is caused by the weight.
> > Our NAPI function often uses the whole budget.
> > Finally, we increase the weight, and the throughput is good.
>
> Could it possibly be related to handling of aggregation?
> Problem must lay somewhere in USB specifics, since as I said
> there are 100Gbps devices running fine with budget of 64.
I think it depends on the platform.
Most of the platforms don't have the same situation.
Besides, I think the platform with 100Gbps device may
have faster CPU than that one which I test.
What would happen, if I set the weight to 256 on the platform
which runs well for the weight of 64?
Doesn't it only influence the slow platform?
Best Regards,
Hayes
next prev parent reply other threads:[~2023-08-09 13:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:02 Error 'netif_napi_add_weight() called with weight 256' Limonciello, Mario
2023-07-31 18:13 ` Jakub Kicinski
2023-07-31 18:23 ` Limonciello, Mario
2023-07-31 20:47 ` Stephen Hemminger
2023-08-07 9:57 ` Hayes Wang
2023-08-07 16:37 ` Jakub Kicinski
2023-08-09 13:11 ` Hayes Wang [this message]
2023-08-09 18:37 ` Jakub Kicinski
2023-08-14 7:07 ` Hayes Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba9b777754f7493ba14faa2dab7d8d59@realtek.com \
--to=hayeswang@realtek.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).