From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8156C3DA7D for ; Thu, 29 Dec 2022 10:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233085AbiL2K0X (ORCPT ); Thu, 29 Dec 2022 05:26:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229992AbiL2K0D (ORCPT ); Thu, 29 Dec 2022 05:26:03 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CCD1132 for ; Thu, 29 Dec 2022 02:26:02 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id g13so26939501lfv.7 for ; Thu, 29 Dec 2022 02:26:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S1Hs/DwPZsz0wqIDur7TzV3TDktZpJYae1IE8frEXoo=; b=hK6JIUGu9CmIqNsWdz+2HdrmzNW2xetYQv224NZz/mnr1OiBbJo/9V1wWqxck6crtw k/RtPWiRMnjSgFdFpry9v3kHYKo8UB7QLKvB9fhaP4+r7hn/Il8z8ZBKW9VVjexI+1r9 fJ4I6ScE2KAdwhfCsogENjUJxjVXegpYggq2MpjFi0o/BFQWX9z4jtIlh1XBsiWZbJb4 wNckPFRyo1PtcM6DFMZTPauN4QIq0Vzf1QutZhu6D5nX04ciRS/4hJnllMv8U2FClVRD OjnVfVK4IRm5IK+3Epu0BFJOmmLQjgM8xFI7YIWepr5lb9aCyGgkvSnBMjWhmd26JuYu 0HQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S1Hs/DwPZsz0wqIDur7TzV3TDktZpJYae1IE8frEXoo=; b=ap3sdwg9NvCw+n5d7r1lKqjrt4Bug14WSY4OuYMlfPiThVi7/qvdz4kjuLEvgyWFCq U1Fr/RxQ3EMpYL4u9XZVmCzzU6iOwx72Vi4plxjDTir3SPTixO6lhmoKQPkpLPDqF706 oc8y8I21PyJ8cuso+9nCwxXzewyPSFfPxGP0cZ7OU69Yqy+9147W79/k+tAAo1eW4+57 jtvvQ4jXo6TtByPvidPT0g6ly8HtPK71sakurKxulYdaLIeD3Zs1x8vruyA+BxBdnY5a cPoY8Y/zJZYSffJn3qOg35g99NXi2pxD/48yPNUlctOk7x7FyqEsdCEgJjOin+GZz7p1 XquQ== X-Gm-Message-State: AFqh2kqSDuFjzQ7JGnKmyrpN546tnI/k97bEaFTn4OvbyhCUN6+T7EfI Km64DWWzBWR3mTgHRBQDGRs9NA== X-Google-Smtp-Source: AMrXdXsupYV6QX8Ph8JDF6Z3D/xD0D27tYEcuRB9b+69Q5P5AW3ID22VaDs6dwmdE8G1bA3GP9myOA== X-Received: by 2002:a05:6512:4002:b0:4b5:637f:f1b0 with SMTP id br2-20020a056512400200b004b5637ff1b0mr8637100lfb.2.1672309560649; Thu, 29 Dec 2022 02:26:00 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id e25-20020ac25479000000b004b58fadba35sm3021671lfn.296.2022.12.29.02.25.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Dec 2022 02:26:00 -0800 (PST) Message-ID: Date: Thu, 29 Dec 2022 11:25:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [RFC PATCH v2 1/3] usb: support Samsung Exynos xHCI Controller Content-Language: en-US To: Daehwan Jung , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Thinh Nguyen , Mathias Nyman , Felipe Balbi Cc: "open list:USB SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , sc.suh@samsung.com, taehyun.cho@samsung.com, jh0801.jung@samsung.com, eomji.oh@samsung.com References: <1672307866-25839-1-git-send-email-dh10.jung@samsung.com> <1672307866-25839-2-git-send-email-dh10.jung@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <1672307866-25839-2-git-send-email-dh10.jung@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 29/12/2022 10:57, Daehwan Jung wrote: > Currently, dwc3 invokes just xhci platform driver without any data. > We add xhci node as child of dwc3 node in order to get data from > device tree. It populates "xhci" child by name during initialization > of host. This patch only effects if dwc3 node has a child named "xhci" > not to disturb original path. > > We add "samsung,exynos-xhci" compatible in xhci platform driver Where? It is not documented. > to support Exynos SOCs. That's so not true. You do nothing to support Exynos SoC here. Please stop pasting incorrect and misleading commit msgs. > We introduce roothub wakeup, which uses roothub > as system wakeup source. It needs xhci platform driver to override > roothub ops. You did not explain why you introduced wakelocks... (...) > if (shared_hcd) { > usb_remove_hcd(shared_hcd); > xhci->shared_hcd = NULL; > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c > index 79d7931c048a..693495054001 100644 > --- a/drivers/usb/host/xhci.c > +++ b/drivers/usb/host/xhci.c > @@ -5502,6 +5502,10 @@ void xhci_init_driver(struct hc_driver *drv, > drv->check_bandwidth = over->check_bandwidth; > if (over->reset_bandwidth) > drv->reset_bandwidth = over->reset_bandwidth; > + if (over->bus_suspend) > + drv->bus_suspend = over->bus_suspend; > + if (over->bus_resume) > + drv->bus_resume = over->bus_resume; > } > } > EXPORT_SYMBOL_GPL(xhci_init_driver); > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index c9f06c5e4e9d..cb9c54a6a22c 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1752,6 +1752,8 @@ struct xhci_hub { > struct xhci_hcd { > struct usb_hcd *main_hcd; > struct usb_hcd *shared_hcd; > + struct wakeup_source *main_wakelock; > + struct wakeup_source *shared_wakelock; Drop wakelocks. This is not related to USB and not needed here. Do you see anywhere else in core kernel code usage of the wakelocks? You got this comment already, didn't you? So why you do not address it? Best regards, Krzysztof