From: Basavaraj Natikar <bnatikar@amd.com>
To: Johan Hovold <johan@kernel.org>,
Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Cc: mathias.nyman@intel.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] xhci: Use pm_runtime_get to prevent RPM on unsupported systems
Date: Thu, 24 Oct 2024 19:09:26 +0530 [thread overview]
Message-ID: <bd6e7234-5fcb-5e36-e159-a0bf298cb047@amd.com> (raw)
In-Reply-To: <ZxpGY_RgP3M7VTv-@hovoldconsulting.com>
On 10/24/2024 6:36 PM, Johan Hovold wrote:
> On Thu, Oct 24, 2024 at 04:51:17PM +0530, Basavaraj Natikar wrote:
>> Use pm_runtime_put in the remove function and pm_runtime_get to disable
>> RPM on platforms that don't support runtime D3, as re-enabling it through
>> sysfs auto power control may cause the controller to malfunction. This
>> can lead to issues such as hotplug devices not being detected due to
>> failed interrupt generation.
>>
>> Fixes: a5d6264b638e ("xhci: Enable RPM on controllers that support low-power states")
>> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>> ---
> This is a new version of this patch:
>
> https://lore.kernel.org/all/20240925161520.2736895-1-Basavaraj.Natikar@amd.com/
>
> so please resend a v3 with a changelog here.
>
> Also remember to CC people reviewing your patches when resubmitting.
Sure Johan, I sent changes in v3.
Thanks,
--
Basavaraj
>
> Johan
prev parent reply other threads:[~2024-10-24 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 11:21 [PATCH] xhci: Use pm_runtime_get to prevent RPM on unsupported systems Basavaraj Natikar
2024-10-24 13:06 ` Johan Hovold
2024-10-24 13:39 ` Basavaraj Natikar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd6e7234-5fcb-5e36-e159-a0bf298cb047@amd.com \
--to=bnatikar@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox