Re: [PATCH] USB: typec: tcpm: Add support for Etek ET7304 Controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/02/2026 19:58, Yuanshen Cao wrote:
> The Etek ET7304 is a USB Type-C Port Controller with USB-PD used on
> the Radxa Cubie A7Z.
> According to the ET7304 datasheet [1] and the vendor BSP source code
> provided by Radxa [2], this controller is the same device as RT1715
> with a different VID.
> 
> Add support for the ET7304 by registering its VID in the driver.
> Tested on Radxa Cubie A7Z.
> 
> [1] https://www.etekmicro.com/wp-content/uploads/datasheets/ET7304_datasheet.pdf
> [2] https://github.com/radxa/allwinner-bsp/commit/156b6578cc173855b41ea311a229403ccbadb17c
> 
> Signed-off-by: Yuanshen Cao <alex.caoys@gmail.com>
> ---
>  .../devicetree/bindings/usb/richtek,rt1711h.yaml |  3 ++-
>  drivers/usb/typec/tcpm/tcpci_rt1711h.c           | 16 +++++++++++++++-

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.

Best regards,
Krzysztof