[PATCH v1 0/2] usb: dwc3: exynos: add support for Exynos2200 variant

[PATCH v1 0/2] usb: dwc3: exynos: add support for Exynos2200 variant

[Ivaylo Ivanov]

Hey folks,

This patchset adds support for the Exynos 2200 to the exynos-dwc3 glue
code. It takes one clock - the link_aclk, and the dwc3 refclk is passed
to the dwc3 subnode, as with gs101.

Best regards,
Ivaylo

Ivaylo Ivanov (2):
  dt-bindings: usb: samsung,exynos-dwc3: add exynos2200 compatible
  usb: dwc3: exynos: add support for Exynos2200 variant

 .../bindings/usb/samsung,exynos-dwc3.yaml         | 15 +++++++++++++++
 drivers/usb/dwc3/dwc3-exynos.c                    |  9 +++++++++
 2 files changed, 24 insertions(+)

-- 
2.43.0

[PATCH v1 1/2] dt-bindings: usb: samsung,exynos-dwc3: add exynos2200 compatible

[Ivaylo Ivanov]

The Exynos2200 SoC has a DWC3 compatible USB controller and can reuse
the existing Exynos glue. Update the dt schema to include the
samsung,exynos2200-dwusb3 compatible for it.

Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
 .../bindings/usb/samsung,exynos-dwc3.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
index 2b3430ceb..beea8e78f 100644
--- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
@@ -13,6 +13,7 @@ properties:
   compatible:
     enum:
       - google,gs101-dwusb3
+      - samsung,exynos2200-dwusb3
       - samsung,exynos5250-dwusb3
       - samsung,exynos5433-dwusb3
       - samsung,exynos7-dwusb3
@@ -73,6 +74,20 @@ allOf:
             - const: link_aclk
             - const: link_pclk
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: samsung,exynos2200-dwusb3
+    then:
+      properties:
+        clocks:
+          minItems: 1
+          maxItems: 1
+        clock-names:
+          items:
+            - const: link_aclk
+
   - if:
       properties:
         compatible:
-- 
2.43.0

Re: [PATCH v1 1/2] dt-bindings: usb: samsung,exynos-dwc3: add exynos2200 compatible

[Krzysztof Kozlowski]

On 15/02/2025 13:34, Ivaylo Ivanov wrote:
> The Exynos2200 SoC has a DWC3 compatible USB controller and can reuse
> the existing Exynos glue. Update the dt schema to include the
> samsung,exynos2200-dwusb3 compatible for it.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
>  .../bindings/usb/samsung,exynos-dwc3.yaml         | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> index 2b3430ceb..beea8e78f 100644
> --- a/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml
> @@ -13,6 +13,7 @@ properties:
>    compatible:
>      enum:
>        - google,gs101-dwusb3
> +      - samsung,exynos2200-dwusb3
>        - samsung,exynos5250-dwusb3
>        - samsung,exynos5433-dwusb3
>        - samsung,exynos7-dwusb3
> @@ -73,6 +74,20 @@ allOf:
>              - const: link_aclk
>              - const: link_pclk
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: samsung,exynos2200-dwusb3
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 1

Drop minItems

With this

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

[PATCH v1 2/2] usb: dwc3: exynos: add support for Exynos2200 variant

[Ivaylo Ivanov]

Add Exynos2200 compatible string and associated driver data. This SoC
requires a Link interface AXI clock.

Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
 drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
index f5d963fae..aa22265c7 100644
--- a/drivers/usb/dwc3/dwc3-exynos.c
+++ b/drivers/usb/dwc3/dwc3-exynos.c
@@ -145,6 +145,12 @@ static void dwc3_exynos_remove(struct platform_device *pdev)
 	regulator_disable(exynos->vdd10);
 }
 
+static const struct dwc3_exynos_driverdata exynos2200_drvdata = {
+	.clk_names = { "link_aclk" },
+	.num_clks = 1,
+	.suspend_clk_idx = -1,
+};
+
 static const struct dwc3_exynos_driverdata exynos5250_drvdata = {
 	.clk_names = { "usbdrd30" },
 	.num_clks = 1,
@@ -177,6 +183,9 @@ static const struct dwc3_exynos_driverdata gs101_drvdata = {
 
 static const struct of_device_id exynos_dwc3_match[] = {
 	{
+		.compatible = "samsung,exynos2200-dwusb3",
+		.data = &exynos2200_drvdata,
+	}, {
 		.compatible = "samsung,exynos5250-dwusb3",
 		.data = &exynos5250_drvdata,
 	}, {
-- 
2.43.0

Re: [PATCH v1 2/2] usb: dwc3: exynos: add support for Exynos2200 variant

[Krzysztof Kozlowski]

On 15/02/2025 13:34, Ivaylo Ivanov wrote:
> Add Exynos2200 compatible string and associated driver data. This SoC
> requires a Link interface AXI clock.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
>  1 file changed, 9 insertions(+)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v1 2/2] usb: dwc3: exynos: add support for Exynos2200 variant

[Thinh Nguyen]

On Sat, Feb 15, 2025, Ivaylo Ivanov wrote:
> Add Exynos2200 compatible string and associated driver data. This SoC
> requires a Link interface AXI clock.
> 
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
>  drivers/usb/dwc3/dwc3-exynos.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/dwc3/dwc3-exynos.c b/drivers/usb/dwc3/dwc3-exynos.c
> index f5d963fae..aa22265c7 100644
> --- a/drivers/usb/dwc3/dwc3-exynos.c
> +++ b/drivers/usb/dwc3/dwc3-exynos.c
> @@ -145,6 +145,12 @@ static void dwc3_exynos_remove(struct platform_device *pdev)
>  	regulator_disable(exynos->vdd10);
>  }
>  
> +static const struct dwc3_exynos_driverdata exynos2200_drvdata = {
> +	.clk_names = { "link_aclk" },
> +	.num_clks = 1,
> +	.suspend_clk_idx = -1,
> +};
> +
>  static const struct dwc3_exynos_driverdata exynos5250_drvdata = {
>  	.clk_names = { "usbdrd30" },
>  	.num_clks = 1,
> @@ -177,6 +183,9 @@ static const struct dwc3_exynos_driverdata gs101_drvdata = {
>  
>  static const struct of_device_id exynos_dwc3_match[] = {
>  	{
> +		.compatible = "samsung,exynos2200-dwusb3",
> +		.data = &exynos2200_drvdata,
> +	}, {
>  		.compatible = "samsung,exynos5250-dwusb3",
>  		.data = &exynos5250_drvdata,
>  	}, {
> -- 
> 2.43.0
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>

Thanks
Thinh