* [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc()
@ 2025-08-19 9:01 Qianfeng Rong
2025-08-19 11:47 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Qianfeng Rong @ 2025-08-19 9:01 UTC (permalink / raw)
To: Bryan O'Donoghue, Heikki Krogerus, Greg Kroah-Hartman,
linux-arm-msm, linux-usb, linux-kernel
Cc: Qianfeng Rong
Replace devm_kzalloc() with devm_kcalloc() in qcom_pmic_typec_pdphy_probe()
and qcom_pmic_typec_port_probe() for safer memory allocation with built-in
overflow protection.
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 +-
drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
index 18303b34594b..c8b1463e6e8b 100644
--- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
+++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
@@ -567,7 +567,7 @@ int qcom_pmic_typec_pdphy_probe(struct platform_device *pdev,
if (!res->nr_irqs || res->nr_irqs > PMIC_PDPHY_MAX_IRQS)
return -EINVAL;
- irq_data = devm_kzalloc(dev, sizeof(*irq_data) * res->nr_irqs,
+ irq_data = devm_kcalloc(dev, res->nr_irqs, sizeof(*irq_data),
GFP_KERNEL);
if (!irq_data)
return -ENOMEM;
diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
index 4fc83dcfae64..8051eaa46991 100644
--- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
+++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
@@ -713,7 +713,7 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev,
if (!res->nr_irqs || res->nr_irqs > PMIC_TYPEC_MAX_IRQS)
return -EINVAL;
- irq_data = devm_kzalloc(dev, sizeof(*irq_data) * res->nr_irqs,
+ irq_data = devm_kcalloc(dev, res->nr_irqs, sizeof(*irq_data),
GFP_KERNEL);
if (!irq_data)
return -ENOMEM;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc()
2025-08-19 9:01 [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc() Qianfeng Rong
@ 2025-08-19 11:47 ` Dmitry Baryshkov
2025-08-19 13:32 ` Bryan O'Donoghue
2025-08-21 7:21 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2025-08-19 11:47 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Bryan O'Donoghue, Heikki Krogerus, Greg Kroah-Hartman,
linux-arm-msm, linux-usb, linux-kernel
On Tue, Aug 19, 2025 at 05:01:24PM +0800, Qianfeng Rong wrote:
> Replace devm_kzalloc() with devm_kcalloc() in qcom_pmic_typec_pdphy_probe()
> and qcom_pmic_typec_port_probe() for safer memory allocation with built-in
> overflow protection.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 +-
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc()
2025-08-19 9:01 [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc() Qianfeng Rong
2025-08-19 11:47 ` Dmitry Baryshkov
@ 2025-08-19 13:32 ` Bryan O'Donoghue
2025-08-21 7:21 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Bryan O'Donoghue @ 2025-08-19 13:32 UTC (permalink / raw)
To: Qianfeng Rong, Heikki Krogerus, Greg Kroah-Hartman, linux-arm-msm,
linux-usb, linux-kernel
On 19/08/2025 10:01, Qianfeng Rong wrote:
> Replace devm_kzalloc() with devm_kcalloc() in qcom_pmic_typec_pdphy_probe()
> and qcom_pmic_typec_port_probe() for safer memory allocation with built-in
> overflow protection.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 +-
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> index 18303b34594b..c8b1463e6e8b 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> @@ -567,7 +567,7 @@ int qcom_pmic_typec_pdphy_probe(struct platform_device *pdev,
> if (!res->nr_irqs || res->nr_irqs > PMIC_PDPHY_MAX_IRQS)
> return -EINVAL;
>
> - irq_data = devm_kzalloc(dev, sizeof(*irq_data) * res->nr_irqs,
> + irq_data = devm_kcalloc(dev, res->nr_irqs, sizeof(*irq_data),
> GFP_KERNEL);
> if (!irq_data)
> return -ENOMEM;
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> index 4fc83dcfae64..8051eaa46991 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -713,7 +713,7 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev,
> if (!res->nr_irqs || res->nr_irqs > PMIC_TYPEC_MAX_IRQS)
> return -EINVAL;
>
> - irq_data = devm_kzalloc(dev, sizeof(*irq_data) * res->nr_irqs,
> + irq_data = devm_kcalloc(dev, res->nr_irqs, sizeof(*irq_data),
> GFP_KERNEL);
> if (!irq_data)
> return -ENOMEM;
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc()
2025-08-19 9:01 [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc() Qianfeng Rong
2025-08-19 11:47 ` Dmitry Baryshkov
2025-08-19 13:32 ` Bryan O'Donoghue
@ 2025-08-21 7:21 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2025-08-21 7:21 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Bryan O'Donoghue, Greg Kroah-Hartman, linux-arm-msm,
linux-usb, linux-kernel
On Tue, Aug 19, 2025 at 05:01:24PM +0800, Qianfeng Rong wrote:
> Replace devm_kzalloc() with devm_kcalloc() in qcom_pmic_typec_pdphy_probe()
> and qcom_pmic_typec_port_probe() for safer memory allocation with built-in
> overflow protection.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 +-
> drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> index 18303b34594b..c8b1463e6e8b 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c
> @@ -567,7 +567,7 @@ int qcom_pmic_typec_pdphy_probe(struct platform_device *pdev,
> if (!res->nr_irqs || res->nr_irqs > PMIC_PDPHY_MAX_IRQS)
> return -EINVAL;
>
> - irq_data = devm_kzalloc(dev, sizeof(*irq_data) * res->nr_irqs,
> + irq_data = devm_kcalloc(dev, res->nr_irqs, sizeof(*irq_data),
> GFP_KERNEL);
> if (!irq_data)
> return -ENOMEM;
> diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> index 4fc83dcfae64..8051eaa46991 100644
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -713,7 +713,7 @@ int qcom_pmic_typec_port_probe(struct platform_device *pdev,
> if (!res->nr_irqs || res->nr_irqs > PMIC_TYPEC_MAX_IRQS)
> return -EINVAL;
>
> - irq_data = devm_kzalloc(dev, sizeof(*irq_data) * res->nr_irqs,
> + irq_data = devm_kcalloc(dev, res->nr_irqs, sizeof(*irq_data),
> GFP_KERNEL);
> if (!irq_data)
> return -ENOMEM;
> --
> 2.34.1
--
heikki
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-21 7:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-19 9:01 [PATCH] usb: typec: qcom-pmic-typec: use kcalloc() instead of kzalloc() Qianfeng Rong
2025-08-19 11:47 ` Dmitry Baryshkov
2025-08-19 13:32 ` Bryan O'Donoghue
2025-08-21 7:21 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).