[Bug 208257] New: Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[Bug 208257] New: Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

            Bug ID: 208257
           Summary: Kingston USB flash drive repeatedly disconnected after
                    "Set SEL for device-initiated U2 failed."
           Product: Drivers
           Version: 2.5
    Kernel Version: 5.7.4
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: julroy67@gmail.com
        Regression: No

Created attachment 289755
  --> https://bugzilla.kernel.org/attachment.cgi?id=289755&action=edit
Fedora kernel 5.7.4 dmesg log

Hello, I have a Kingston 32GB USB flash drive failing to get mounted. Dmesg
show that the flash drive gets repeatedly disconnected after "Set SEL for
device-initiated U2 failed."

I'm able to reproduce the problem on the following laptops:
* Dell XPS 7390 (connected through official Dell USB-C to USB-A adapter)
* Sony Vaio SVP132A1CM (no adapter, directly connected)

The USB drives works on the following devices:
* Multiple office desktop computer, all running Windows
* Nvidia Shield TV 2015 edition (4.9.140 kernel)

Please let me know if I can do something to help out or if some additional
information is needed.

Note:
I first reported the bug as #1801627 on Fedora's Bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1801627

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

Julien Humbert (julroy67@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289755|0                           |1
        is obsolete|                            |

--- Comment #1 from Julien Humbert (julroy67@gmail.com) ---
Created attachment 290155
  --> https://bugzilla.kernel.org/attachment.cgi?id=290155&action=edit
Fedora kernel 5.7.7 dmesg log

Still the same as of kernel 5.7.7.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #2 from Alan Stern (stern@rowland.harvard.edu) ---
> Still the same as of kernel 5.7.7.

Have you tried disabling Link Power Management?  Before you plug in the 
flash drive, do:

   sudo echo 0951:1666:k >/sys/module/usbcore/parameters/quirks

Alan Stern

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #3 from Julien Humbert (julroy67@gmail.com) ---
(In reply to Alan Stern from comment #2)
> Have you tried disabling Link Power Management?  Before you plug in the 
> flash drive, do:
> 
>    sudo echo 0951:1666:k >/sys/module/usbcore/parameters/quirks

Incredible, that worked!
The flash drive gets mounted and I'm able to access the files on it.

Not sure what the next step, but thanks!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #4 from Alan Stern (stern@rowland.harvard.edu) ---
On Wed, Jul 08, 2020 at 12:14:20PM +0000, bugzilla-daemon@bugzilla.kernel.org
wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=208257
> 
> --- Comment #3 from Julien Humbert (julroy67@gmail.com) ---
> (In reply to Alan Stern from comment #2)
> > Have you tried disabling Link Power Management?  Before you plug in the 
> > flash drive, do:
> > 
> >    sudo echo 0951:1666:k >/sys/module/usbcore/parameters/quirks
> 
> Incredible, that worked!
> The flash drive gets mounted and I'm able to access the files on it.
> 
> Not sure what the next step, but thanks!

Ideally we'd like to know whether this problem affects only your flash 
drive or all drives of the same type, and whether it shows up only on 
your computer or on lots of different computers.  Can you test for these 
things?

Alan Stern

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #5 from Julien Humbert (julroy67@gmail.com) ---
Created attachment 290557
  --> https://bugzilla.kernel.org/attachment.cgi?id=290557&action=edit
Sony Vaio kernel 5.7.10 dmesg log

Sorry for the delay.

The exact same thing happens on my Sony Vaio SVP132A1CM (dmesg logs attached).
Disabling Link Power Management before plugging in the flash drive with "sudo
echo 0951:1666:k >/sys/module/usbcore/parameters/quirks" fixes the issue.

I have no other laptop at hand to test, but I hope you can get the informations
needed to fix it.

Thank you!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #6 from Alan Stern (stern@rowland.harvard.edu) ---
Created attachment 290577
  --> https://bugzilla.kernel.org/attachment.cgi?id=290577&action=edit
Patch to add NO_LPM quirk

Here is a patch to add the NO_LPM quirk for the Kingston DataTraveler.  Can you
build a kernel to test it?  If you can't, the people on the Fedora bug report
may be able to help.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #7 from Alan Stern (stern@rowland.harvard.edu) ---
It has been about a month.  Any progress on testing the patch?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #8 from Julien Humbert (julroy67@gmail.com) ---
I'm really sorry, nothing moved at all.
I asked for some help on the Red Hat Bugzilla, because I'm not sure how to
compile the kernel with the patch, and I'm not even sure I could boot it on my
main computer which is using secure boot.

I really hope I can make sure that this gets included for Fedora 33, I should
try to contact some of the maintainers directly to get some movement.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

Hans de Goede (jwrdegoede@fedoraproject.org) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwrdegoede@fedoraproject.or
                   |                            |g

--- Comment #9 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
I've (In reply to Julien Humbert from comment #8)
> I asked for some help on the Red Hat Bugzilla, because I'm not sure how to

I have prepared a Fedora kernel test-build with the patch added, this is
currently building here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=54473681

Note it takes a couple of hour for the build to complete.

See here for some generic instructions on installing a kernel test-build
directly from koji (the Fedora buildsystem):
https://fedorapeople.org/~jwrdegoede/kernel-test-instructions.txt

> compile the kernel with the patch, and I'm not even sure I could boot it on
> my main computer which is using secure boot.

You will need to disable secure-boot I'm afraid as test kernel-builds are not
signed.

If you cannot do this from within your BIOS you can instead run:

mokutil --disable-validation

This will ask you to pick a password (I would advise using 123456789) and then
on reboot will ask you to enter the nth char of the password a couple of times,
to prove you have physical access to the machine *and* that it was you who
requested the change.

This temporarily disables validation at the shim level, once you are done you
can re-enable validation by running:

mokutil --enable-validation

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #10 from Julien Humbert (julroy67@gmail.com) ---
(In reply to Hans de Goede from comment #9)
> I have prepared a Fedora kernel test-build with the patch added, this is
> currently building here:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=54473681

Thank you for the build and the instructions!

I've tested out the kernel and everything works fine, the Kingston USB flash
drive gets mounted, I can read and copy to it without any problem.

So it took some time, but the patch is working!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #11 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
(In reply to Julien Humbert from comment #10)
> I've tested out the kernel and everything works fine, the Kingston USB flash
> drive gets mounted, I can read and copy to it without any problem.
> 
> So it took some time, but the patch is working!

Great, so lets submit the patch upstream then. Alan do you want to submit the
quirk upstream, or shall I submit it?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #12 from Alan Stern (stern@rowland.harvard.edu) ---
I'll take care of it.  I was just waiting for confirmation that the patch
worked okay.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

--- Comment #13 from Hans de Goede (jwrdegoede@fedoraproject.org) ---
(In reply to Alan Stern from comment #12)
> I'll take care of it.  I was just waiting for confirmation that the patch
> worked okay.

Ok, I saw the patch, LGTM. So I believe this bug can be closed then ?

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 208257] Kingston USB flash drive repeatedly disconnected after "Set SEL for device-initiated U2 failed."

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=208257

Julien Humbert (julroy67@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |CODE_FIX

--- Comment #14 from Julien Humbert (julroy67@gmail.com) ---
Tested and fixed on Fedora kernel 5.9.8-200.fc33.x86_64.

Thanks a lot for the help fixing the issue!

-- 
You are receiving this mail because:
You are watching the assignee of the bug.