linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: linux-usb@vger.kernel.org
Subject: [Bug 214789] ehci-hcd.c ISR
Date: Thu, 21 Oct 2021 16:13:23 +0000	[thread overview]
Message-ID: <bug-214789-208809-0sL95uFuyL@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-214789-208809@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=214789

--- Comment #4 from Scott Arnold (scott.c.arnold@nasa.gov) ---
Hello,
Timing card is not receiving interrupts when sharing a IRQ (16) with the
ehci-hcd driver and the 5.11.17  (also tried 5.14.13) kernel.
I changed the spin_lock/spin_unlock back to spin_lock_irqsave/irqrestore in
ehci_irq in the 5.14.13 kernel and timing card now getting interrupts as
expected.
The 5.3 (and probably prior although I have not checked) are using the
irqsave/restore versions of spinlock in ehci_irq.
From 5.3:
       /*
         * For threadirqs option we use spin_lock_irqsave() variant to prevent
         * deadlock with ehci hrtimer callback, because hrtimer callbacks run
         * in interrupt context even when threadirqs is specified. We can go
         * back to spin_lock() variant when hrtimer callbacks become threaded.
         */
        spin_lock_irqsave(&ehci->lock, flags);

Thanks
Scott

-----Original Message-----
From: bugzilla-daemon@bugzilla.kernel.org <bugzilla-daemon@bugzilla.kernel.org> 
Sent: Thursday, October 21, 2021 11:03 AM
To: Arnold, Scott C. (JSC-CD13)[SGT, INC] <scott.c.arnold@nasa.gov>
Subject: [EXTERNAL] [Bug 214789] ehci-hcd.c ISR

https://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.kernel.org%2Fshow_bug.cgi%3Fid%3D214789&amp;data=04%7C01%7Cscott.c.arnold%40nasa.gov%7Ce7de881063ce46edc00808d994ac34f6%7C7005d45845be48ae8140d43da96dd17b%7C0%7C0%7C637704289608055302%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=klAQp1A7%2FNOCGgcfJ29A2EQwDD%2Fa5UQbX%2BLUaHU5fb4%3D&amp;reserved=0

--- Comment #3 from Alan Stern (stern@rowland.harvard.edu) --- Can you provide
more information about exactly what goes wrong?  And why shared IRQs should
make any difference?

--
You may reply to this email to add a comment.

You are receiving this mail because:
You reported the bug.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2021-10-21 16:13 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21  4:29 [Bug 214789] New: ehci-hcd.c ISR bugzilla-daemon
2021-10-21  5:56 ` Greg KH
2021-10-21  5:56 ` [Bug 214789] " bugzilla-daemon
2021-10-21 15:42 ` bugzilla-daemon
2021-10-21 16:02 ` bugzilla-daemon
2021-10-21 16:13 ` bugzilla-daemon [this message]
2021-10-21 19:27 ` bugzilla-daemon
2021-10-21 19:36 ` bugzilla-daemon
2021-10-21 19:37 ` bugzilla-daemon
2021-10-21 19:46 ` bugzilla-daemon
2021-10-21 20:04 ` bugzilla-daemon
2021-10-22  8:53   ` Johan Hovold
2021-10-22  8:53 ` bugzilla-daemon
2021-10-25 13:19   ` Johan Hovold
2021-10-25 13:19 ` bugzilla-daemon
2021-10-26 21:49 ` bugzilla-daemon
2021-10-27  2:05 ` bugzilla-daemon
2021-10-27 17:15 ` bugzilla-daemon
2021-10-27 20:07 ` bugzilla-daemon
2021-10-27 20:39 ` bugzilla-daemon
2021-10-27 21:14 ` bugzilla-daemon
2021-10-29 15:41 ` bugzilla-daemon
2021-11-01 19:07 ` bugzilla-daemon
2021-11-01 19:41 ` bugzilla-daemon
2021-11-01 19:49 ` bugzilla-daemon
2021-11-05 17:10 ` bugzilla-daemon
2021-11-05 19:39   ` Alan Stern
2021-11-16 19:40     ` Krzysztof Wilczyński
2021-11-05 18:56 ` bugzilla-daemon
2021-11-05 19:39 ` bugzilla-daemon
2021-11-16 19:40 ` bugzilla-daemon
2021-12-04  0:02 ` bugzilla-daemon
2021-12-04  0:05 ` bugzilla-daemon
2021-12-04  0:27 ` bugzilla-daemon
2021-12-04  0:29 ` bugzilla-daemon
2021-12-06 21:44 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-214789-208809-0sL95uFuyL@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).