[Bug 218762] New: USB string order in dmesg

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=218762

            Bug ID: 218762
           Summary: USB string order in dmesg
           Product: Drivers
           Version: 2.5
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P3
         Component: USB
          Assignee: drivers_usb@kernel-bugs.kernel.org
          Reporter: ddtpvtxm@gmail.com
        Regression: No

Hi,

Is there any good reason why the code
https://github.com/torvalds/linux/blob/c85af715cac0a951eea97393378e84bb49384734/drivers/usb/core/hub.c#L2361
is declaring string (show_string) values in a different order than they are
specified in dev_info?

        dev_info(&udev->dev,
                "New USB device strings: Mfr=%d, Product=%d,
SerialNumber=%d\n",
                udev->descriptor.iManufacturer,
                udev->descriptor.iProduct,
                udev->descriptor.iSerialNumber);
        show_string(udev, "Product", udev->product);
        show_string(udev, "Manufacturer", udev->manufacturer);
        show_string(udev, "SerialNumber", udev->serial);


Now
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 4-1: Product: BM5100ADW series
usb 4-1: Manufacturer: Pantum
usb 4-1: SerialNumber: CK1A8823765

Expected
usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
usb 4-1: Manufacturer: Pantum
usb 4-1: Product: BM5100ADW series
usb 4-1: SerialNumber: CK1A8823765

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.