[Bug 220272] Latent race condition in USB code unveiled with optimized memset_64.S

[bugzilla-daemon@kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=220272

--- Comment #17 from Michał Pecio (michal.pecio@gmail.com) ---
I also had a look at this LLM generated "report" and I can't see how the
alleged issues are supposed to be real.

1. Replacing wmb() with dma_wmb() possibly makes sense, though on x86 wmb() is
stronger than dma_wmb() so it can't be the cause of your problem. Other PCI
drivers made such change for performance rather than correctness.

2. I'm not familiar with xhci->mutex use so no comment, but the alleged
deadlock probably doesn't exist as there is no asynchronous completion callback
here.

3. Pedantry with no functional impact.

4. The driver will abort a hanging command and signal the completion.

5. We immediately return so we don't go to the out label. No bug.

6. mutex != spinlock. No bug.

7. I see no bug. No static analyzer was run so that part is made up.

8. Doesn't matter if the value is zero.

9. No arithmetic is done on this variable.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.