Re: [bug report] usb: gadget: u_serial: Implement remote wakeup capability

[Dan Carpenter <dan.carpenter@linaro.org>]

On Wed, Apr 30, 2025 at 04:06:00PM +0530, Prashanth K wrote:
> 
> 
> On 30-04-25 01:39 pm, Dan Carpenter wrote:
> > Hello Prashanth K,
> > 
> > Commit 3baea29dc0a7 ("usb: gadget: u_serial: Implement remote wakeup
> > capability") from Apr 24, 2025 (linux-next), leads to the following
> > Smatch static checker warning:
> > 
> > drivers/usb/gadget/function/u_serial.c:1511 gserial_suspend() warn: double unlock 'global &serial_port_lock' (orig line 1505)
> > drivers/usb/gadget/function/u_serial.c:1514 gserial_suspend() warn: double unlock 'flags' (orig line 1505)
> > 
> > drivers/usb/gadget/function/u_serial.c
> >     1501         }
> >     1502 
> >     1503         if (port->write_busy || port->write_started) {
> >     1504                 /* Wakeup to host if there are ongoing transfers */
> >     1505                 spin_unlock_irqrestore(&serial_port_lock, flags);
> >                                                  ^^^^^^^^^^^^^^^^  ^^^^^
> > We unlock here.
> > 
> >     1506                 if (!gserial_wakeup_host(gser))
> > 
> > Assume gserial_wakeup_host() fails so we don't return on the next line.
> > 
> >     1507                         return;
> >     1508         }
> >     1509 
> >     1510         spin_lock(&port->port_lock);
> > --> 1511         spin_unlock(&serial_port_lock);
> >                              ^^^^^^^^^^^^^^^^^
> > Double unlock.
> > 
> >     1512         port->suspended = true;
> >     1513         port->start_delayed = true;
> >     1514         spin_unlock_irqrestore(&port->port_lock, flags);
> >                                                           ^^^^^
> > IRQs were already enabled.  Which is probably fine, I don't know.
> > 
> >     1515 }
> > 
> > regards,
> > dan carpenter
> 
> Can you send a patch, or should i fix it? Let me know.

Could you could send the patch?  Thanks!

regards,
dan carpenter