From: "Stanley Chang[昌育德]" <stanley_chang@realtek.com>
To: Sergey Shtylyov <s.shtylyov@omp.ru>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] usb: dwc3: add missing of_node_put and platform_device_put
Date: Tue, 14 Nov 2023 11:12:01 +0000 [thread overview]
Message-ID: <c528787cd608476980a9c07123366c92@realtek.com> (raw)
In-Reply-To: <e1686031-aa5a-5692-50c3-0382d32641e6@omp.ru>
Hi Sergey,
> On 11/14/23 1:16 PM, Stanley Chang wrote:
>
> > of_get_compatible_child performs an of_node_get, so an of_node_get is
>
> You mean of_node_put is required?
Right, it is of_node_put.
I'm sorry for the typo.
Thanks,
Stanley
> > required. Add platform_device_put to match with of_find_device_by_node.
> >
> > Fixes: 34c200483569 ("usb: dwc3: add Realtek DHC RTD SoC dwc3 glue layer
> driver")
> > Signed-off-by: Stanley Chang <stanley_chang@realtek.com>
> > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
> > ---
> > v1 to v2 change:
> > 1. Modify the commit message.
> > 2. Add of_node_get in the of_property_read_string() error path.
> [...]
>
> MBR, Sergey
prev parent reply other threads:[~2023-11-14 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 10:16 [PATCH v2] usb: dwc3: add missing of_node_put and platform_device_put Stanley Chang
2023-11-14 10:35 ` Sergey Shtylyov
2023-11-14 11:12 ` Stanley Chang[昌育德] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c528787cd608476980a9c07123366c92@realtek.com \
--to=stanley_chang@realtek.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox