From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC9A1C04AB3 for ; Fri, 10 May 2019 08:41:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F8702087E for ; Fri, 10 May 2019 08:41:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="nAlW73II" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727076AbfEJIlw (ORCPT ); Fri, 10 May 2019 04:41:52 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:39196 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727053AbfEJIlw (ORCPT ); Fri, 10 May 2019 04:41:52 -0400 Received: by mail-lf1-f68.google.com with SMTP id f1so3554518lfl.6 for ; Fri, 10 May 2019 01:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XWVQYZW0e0mAZnrT6kZIleP94afetnob6Kz71W2tW1s=; b=nAlW73IIqiP2tVVMjnR5Ain4JH0DB31r8x+k6xd/94bonSpo+4/3BhVoBxIlFNW7ZF WJb1ow7gVrkOhX4mNb/hmU/ZaNis5dQK9hDK+3GmUfqAdkGJzIKjSp1OlWON/U0unlne W9Zu+k0kJD9BEqq+xj+BqgZ5PmP2cZVVMeC1BUqmqKKh6J5dGeoNMBIYi+S/2n+HzgCK ZV8nJ6KZ6O0PByYQOCgnPl5O/+8PgGGi3aykf3E4OJv41c6/dkBwoVOOwfyHUBH1KgKR KnOHE2K4yMLgcODMBA8Cf2qkiky9/QXw1f2/+TuIozhO8DXP8ja7spNt5yKlXx9JLYER G89Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XWVQYZW0e0mAZnrT6kZIleP94afetnob6Kz71W2tW1s=; b=YkFFTNth/Cazn4S3By3AktgE2eIw3QAxAUfqZK+eljgt6oBR/mdRRJLvZBldheopep Uox/xPSwloBUgBEntdXThZDfOL2RCUgdFZ6QskYubMnxrx2BHyy8zQK5fIN/jO30CpOS ZGM82RXnIrkM+S21yK3GtCfRW4xtSAEt62cSSpObsQ4CUn1vHeSl17pTRgUAKXeCkpHA zjuIl5q8cO3h9rUuqOL9xZwiw00NkCUdxD1UttSh3+7ewsKwd540BqvMptCp75kTLPAU 1jjyAQHLW07+jbu7yZ16jgmU9/VDEZmE+gQb4VEJDploBPuf5YSWcYxhI9wpjwC6iUE+ S3fQ== X-Gm-Message-State: APjAAAWLR1D9KR2SHN75q+yUbJ0w5W92ZsAVNr3f1R8pSMqcd5Ym4/JT fa17kKdTZHFzgjLJzUWEIBAHzw== X-Google-Smtp-Source: APXvYqxa0gDwKVIvoIVLSvqZG4CvLR8GrbDD2gAgj5EAbg/qfY7uDNcZIbxKt344h2ssuiI4uD2CvA== X-Received: by 2002:a19:5045:: with SMTP id z5mr5484946lfj.108.1557477710033; Fri, 10 May 2019 01:41:50 -0700 (PDT) Received: from [192.168.0.199] ([31.173.83.158]) by smtp.gmail.com with ESMTPSA id o7sm1113095ljh.57.2019.05.10.01.41.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 May 2019 01:41:49 -0700 (PDT) Subject: Re: [PATCH v2 08/15] usb: renesas_usbhs: move flags macros To: Chris Brandt , Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda Cc: Geert Uytterhoeven , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20190509201142.10543-1-chris.brandt@renesas.com> <20190509201142.10543-9-chris.brandt@renesas.com> From: Sergei Shtylyov Message-ID: Date: Fri, 10 May 2019 11:41:38 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190509201142.10543-9-chris.brandt@renesas.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 09.05.2019 23:11, Chris Brandt wrote: > Move flags macros to header file so they can be used by other files. > > Signed-off-by: Chris Brandt > --- > drivers/usb/renesas_usbhs/common.c | 7 ------- > drivers/usb/renesas_usbhs/common.h | 10 ++++++++++ > 2 files changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > index 249fbee97f3f..efb26ffd9809 100644 > --- a/drivers/usb/renesas_usbhs/common.c > +++ b/drivers/usb/renesas_usbhs/common.c > @@ -44,13 +44,6 @@ > */ > > > -#define USBHSF_RUNTIME_PWCTRL (1 << 0) > - > -/* status */ > -#define usbhsc_flags_init(p) do {(p)->flags = 0; } while (0) > -#define usbhsc_flags_set(p, b) ((p)->flags |= (b)) > -#define usbhsc_flags_clr(p, b) ((p)->flags &= ~(b)) > -#define usbhsc_flags_has(p, b) ((p)->flags & (b)) > Why leave 3 empty lines? > /* > * platform call back [...] MBR, Sergei