From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: "Linyu Yuan (QUIC)" <quic_linyyuan@quicinc.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"Jack Pham (QUIC)" <quic_jackp@quicinc.com>
Subject: Re: [PATCH 1/5] usb: host: xhci: use ffs() in xhci_mem_init()
Date: Wed, 16 Feb 2022 12:53:08 +0300 [thread overview]
Message-ID: <c6cf661b-b3df-281f-3cb0-8899c95f9ce2@gmail.com> (raw)
In-Reply-To: <DM8PR02MB819861F71713D5539EF66D12E3359@DM8PR02MB8198.namprd02.prod.outlook.com>
On 2/16/22 12:47 PM, Linyu Yuan (QUIC) wrote:
> that's correct, from my view, one line is good,
>
> What's your suggestion ? two lines ?
Yes, and it is not just my suggestion -- it's the kernel coding style.
[...]
MBR, Sergey
next prev parent reply other threads:[~2022-02-16 9:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 6:59 [PATCH 0/5] usb: xhci: fix of some code/comment Linyu Yuan
2022-02-16 6:59 ` [PATCH 1/5] usb: host: xhci: use ffs() in xhci_mem_init() Linyu Yuan
2022-02-16 9:41 ` Sergei Shtylyov
2022-02-16 9:47 ` Linyu Yuan (QUIC)
2022-02-16 9:53 ` Sergei Shtylyov [this message]
2022-02-16 9:57 ` Linyu Yuan (QUIC)
2022-02-16 10:11 ` Sergei Shtylyov
2022-02-16 10:34 ` Greg Kroah-Hartman
2022-02-16 6:59 ` [PATCH 2/5] usb: host: xhci: fix a comment typo " Linyu Yuan
2022-02-16 6:59 ` [PATCH 3/5] usb: host: xhci: update hci_version operation in xhci_gen_setup() Linyu Yuan
2022-02-16 6:59 ` [PATCH 4/5] usb: host: xhci: add blank line in xhci_halt() Linyu Yuan
2022-02-16 6:59 ` [PATCH 5/5] usb: host: xhci: remove init to some ret/retval Linyu Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6cf661b-b3df-281f-3cb0-8899c95f9ce2@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_linyyuan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox