Linux USB
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Bastien Nocera <hadess@hadess.net>, linux-usb@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v4] USB: Fix device driver race
Date: Fri, 24 Jul 2020 13:18:26 +0300	[thread overview]
Message-ID: <cb19dbf0-8f4f-d60c-a93f-bd3b0ae67d09@gmail.com> (raw)
In-Reply-To: <ee32a093d43fe6631617c203ea7c86cb700ceac5.camel@hadess.net>

Hello!

On 24.07.2020 11:59, Bastien Nocera wrote:

> When a new device with a specialised device driver is plugged in, the
> new driver will be modprobe()'d but the driver core will attach the
> "generic" driver to the device.
> 
> After that, nothing will trigger a reprobe when the modprobe()'d device
> driver has finished initialising, as the device has the "generic"
> driver attached to it.
> 
> Trigger a reprobe ourselves when new specialised drivers get registered.
> 
> Fixes: 88b7381a939d

    It's strange that nobody has noticed... you need to cite the commit 
summary here as well, enclosed into ("").

> Signed-off-by: Bastien Nocera <hadess@hadess.net>
[...]
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> index f81606c6a35b..6731a8e104bc 100644
> --- a/drivers/usb/core/driver.c
> +++ b/drivers/usb/core/driver.c
[...]

MBR, Sergei

  reply	other threads:[~2020-07-24 10:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24  8:59 [PATCH v4] USB: Fix device driver race Bastien Nocera
2020-07-24 10:18 ` Sergei Shtylyov [this message]
2020-07-24 15:16   ` Bastien Nocera
2020-07-24 10:32 ` Andy Shevchenko
2020-07-24 10:39   ` Andy Shevchenko
2020-07-24 15:19     ` Bastien Nocera
2020-07-24 15:19   ` Bastien Nocera
2020-07-24 15:27   ` Alan Stern
2020-07-24 16:52     ` Bastien Nocera
2020-07-24 17:08       ` Alan Stern
2020-07-24 17:14         ` Bastien Nocera
2020-07-25  9:17           ` Bastien Nocera
2020-07-24 20:05     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cb19dbf0-8f4f-d60c-a93f-bd3b0ae67d09@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hadess@hadess.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox