From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022A2C43465 for ; Mon, 21 Sep 2020 15:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9207920BED for ; Mon, 21 Sep 2020 15:45:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="RPZ4BuPJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727767AbgIUPpO (ORCPT ); Mon, 21 Sep 2020 11:45:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727174AbgIUPpO (ORCPT ); Mon, 21 Sep 2020 11:45:14 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B473C061755; Mon, 21 Sep 2020 08:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:References:Cc:To:From:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=4YJsh+/JMJiEcRz2N7elI20o3ohDyLzBBt3UWLvYKAc=; b=RPZ4BuPJshcqBkKw0jQ4zUZomt 50RRZpvsMeVUMUBYc+Mz1JOG4MW3jkpnNZ9slvRv0ft9uK1Ud7y2+Ot/9kEuIiOyHaQ1cVMDAV1zh /Rz2UrxtRfoZNrAVfhHsQ4CszIFQ/nHpNTaDeSxJoKSsQLgW5Bjk1jGfLhnfax8pTTJI7vGjPuPCW VYpP9tkHFTPO8OD7wY+ic1zfCPf8JYJC90FoTJro96WKbSm84r5nw1I5csQJApIJOvxQ4b7BsFzc9 0ZM2a8vO6o1hki5+Iu5/cb/oDVYzyCNBDK6qb4a31WLWVVGrz/MPvKSw9r+NKwhxnpPznBKW8Vilp BbzOlftw==; Received: from [2601:1c0:6280:3f0:897c:6038:c71d:ecac] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKO01-0003GP-5T; Mon, 21 Sep 2020 15:45:05 +0000 Subject: Re: [PATCH -next] phy: fix USB_LGM_PHY warning & build errors From: Randy Dunlap To: LKML , USB list Cc: Li Yin , Vadivel Murugan R , Kishon Vijay Abraham I , Vinod Koul , Greg Kroah-Hartman References: Message-ID: Date: Mon, 21 Sep 2020 08:45:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Ping. Still seeing this in linux-next. On 9/17/20 10:51 AM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix a Kconfig warning that is causing lots of build errors > when USB_SUPPORT is not set. > > USB_PHY depends on USB_SUPPORT but "select" doesn't care about > dependencies, so this driver should also depend on USB_SUPPORT. > It should not select USB_SUPPORT. > > WARNING: unmet direct dependencies detected for USB_PHY > Depends on [n]: USB_SUPPORT [=n] > Selected by [m]: > - USB_LGM_PHY [=m] > > Signed-off-by: Randy Dunlap > Cc: Li Yin > Cc: Vadivel Murugan R > Cc: Kishon Vijay Abraham I > Cc: Vinod Koul > --- > drivers/phy/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20200917.orig/drivers/phy/Kconfig > +++ linux-next-20200917/drivers/phy/Kconfig > @@ -51,6 +51,7 @@ config PHY_XGENE > > config USB_LGM_PHY > tristate "INTEL Lightning Mountain USB PHY Driver" > + depends on USB_SUPPORT > select USB_PHY > select REGULATOR > select REGULATOR_FIXED_VOLTAGE > -- ~Randy