From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA81E18A6C6 for ; Wed, 9 Oct 2024 08:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728463366; cv=none; b=hNUM9huzOCbdCJab+QkKcmnDgcOyMw2+SWoQ1CDqw7nWgX1O6rynDGheV91u4fKCDXMZc/FRPoClqfoE4vNIsq9no4V5twj976zE29QxQx7HNDad9Zw+Z+MXWuJssKPcpbpQeaTJhCxNEi7z5Uilbgw9a+bAstcXFRNNB8wiiKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728463366; c=relaxed/simple; bh=XhJiHPGo1+eCnZwKrwKtZoj+qGtS2ActqBF7GqOTjZQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tXk385DgHv+9qn43EnJ/TP4STrIUbtJSf8OOU2Qs/jQe+4nDzZGRFLnwc3TpyvJy7cQeK/SHeqANdaQABkHF68eVWw0IXKjiSrbLQrDOKCiTTx1qCoUzaKs4wBxIdPj19e09eNLREkA9D8BdmACcLTh75npxSdVYJcaqgLSVg3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=N3MsA3xX; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="N3MsA3xX" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a99650da839so298584066b.2 for ; Wed, 09 Oct 2024 01:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1728463363; x=1729068163; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NCo1GlPGMO9qRjYk6NqblAPH+ivDBMcmdikYhCEoAX0=; b=N3MsA3xXYhA8BGicfckJzTKfIILQJylZFKBHAuYRpUMZCEwA/MGo1xlfMjbYrppwMZ 1ABbNIaLsfWy+n8Jmcp8wGFMp3p0uj+e1t3wYhI4qL9QNlpICl5LZX23lNnVkMmbaHBv DEp/Ve+HON0bMnYDM8TZ1DjHpQ9m3QPEuyubq4S6VFwJ1cWDVuFZc2s02I1dWMgjGU0D i6gu7v4tWYpiAjOym8BXENecX5/8vPT46O4acX3v8gMjc51e0O2rc5avmUq9JgCtisGp lrggl7V+vqye8HtVY5xMd67EFvelC/sNNaMhrfo/TW+jzqv8cJhyNmH606Mqlv595Z+q xSGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728463363; x=1729068163; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NCo1GlPGMO9qRjYk6NqblAPH+ivDBMcmdikYhCEoAX0=; b=xIQy7osl1cid5jehJe8SxaESs7yNlWDdrtewKNGmjNtNBxGPj9hPUWuURN+zwu0bMS JaYcXv7lYMTcyHc2fyx54U0ncMRKDNxOFdqKZ8GdN+JVrdVUPC1aruNJUFPW272v+rif S2WNiN3WN8dnoTU1n2AarvhVbJzVgcICk8c8Cj7yIc+Ksg+/a0pHfWBB/9QQ5ZzGzHlS 0qOuTOsENgYWJw5C7byPTDcKFvJEF6EuI3A0tVK9hGoT3BR0tJkoeIS2xuGLWkUhnKDz S29EFZIApI6xa+V6O6diznprcEhEl/YBPiAeiKPhAsl3fPz9SmN8lOir03NhFf8ZDgui aSQQ== X-Forwarded-Encrypted: i=1; AJvYcCUF7Kn/jbmjV8c/DWp7G2cUoSchMnq4PuZWRAa1W1kpQcIYMejhTdJBQjHh1VSCoSyo5OcaRu87fYU=@vger.kernel.org X-Gm-Message-State: AOJu0YwmWvRAeZvmx2l4Q/9TJ5HlaZtNRC1+jea8W4j+WnnftEbpggyz Sw5nE72rj+L5hwI3hiFtfmdxwlMX8HXSsEpv23vQlYsPj0xbTDL0b5ERUNNJNsY= X-Google-Smtp-Source: AGHT+IH65Py6ZoVFXJXAzrfoxCpg11Zu8PXx18r+jrhrvKhS9cBYCLJYMJJAgnToJzsiU/Uro8/0AA== X-Received: by 2002:a17:906:6a05:b0:a77:c95e:9b1c with SMTP id a640c23a62f3a-a998d1f6694mr148213966b.27.1728463363024; Wed, 09 Oct 2024 01:42:43 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.23]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9957c683d1sm365002866b.203.2024.10.09.01.42.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2024 01:42:42 -0700 (PDT) Message-ID: Date: Wed, 9 Oct 2024 11:42:40 +0300 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 15/16] arm64: dts: renesas: rzg3s-smarc: Enable USB support Content-Language: en-US To: Geert Uytterhoeven Cc: vkoul@kernel.org, kishon@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, magnus.damm@gmail.com, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, yoshihiro.shimoda.uh@renesas.com, biju.das.jz@bp.renesas.com, ulf.hansson@linaro.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Claudiu Beznea References: <20240822152801.602318-1-claudiu.beznea.uj@bp.renesas.com> <20240822152801.602318-16-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, Geert, On 08.10.2024 18:16, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Thu, Aug 22, 2024 at 5:28 PM Claudiu wrote: >> From: Claudiu Beznea >> >> Enable USB support (host, device, USB PHYs and sysc). >> >> Signed-off-by: Claudiu Beznea > > Thanks for your patch! > >> --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >> +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi >> @@ -144,3 +188,20 @@ &sdhi1 { >> max-frequency = <125000000>; >> status = "okay"; >> }; >> + >> +&sysc { >> + status = "okay"; >> +}; >> + > > To avoid regressions (/sys/devices/soc0/ disappearing), enabling sysc > is a dependency for "[PATCH 05/16] soc: renesas: sysc: Move RZ/G3S > SoC detection on SYSC driver", so I think it makes sense to change > its status to "okay" in r9a08g045.dtsi instead, and spin that off into > its own patch. Good point! I'll add the dtsi changes into "[PATCH 05/16] soc: renesas: sysc: Move RZ/G3S SoC detection on SYSC driver". Thank you, Claudiu Beznea I am not super-worried, so doing the driver and DTS > changes in separate patches should be fine, as long as they meet each > other in next or upstream. > > The rest LGTM. > > Gr{oetje,eeting}s, > > Geert >