From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD4B73F8229; Mon, 31 Aug 2026 12:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788179354; cv=none; b=al+IWX/yqs4plgbxX0ut9C3zvVl5uUKShE1F0sVgB86G8l6hbe4Rf/x0R1pO00XWHE2bEL1Fr5R63r7wBp3rKs9KPg3Zpb08lzIAuDD6szQTzpcPOvcwpsttZmd1fW9+noq9qJpulYpYpDZ3aHq/79T9WggGNw9zVDt5hefR3/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788179354; c=relaxed/simple; bh=l0MaT3Pi5uGiiDDeoLkgWy81tFD6Pr72ylJ0STO1Rdw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=twReWTBjB9/9AHjB5PhNixE+z2T55/5s0ZBU3t9Wps4uk/eC1vtLQq4i9AzUjHo7vB9sPmOM+OxJOmyecasvj5x7QhljKhJPBTeJAARZqJuGmhXDcOWkPkb+2c++ULBTP4UmO04WqnPn4athUMCoYeWRG3+J9XDs0AAL1gFx+5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Vw3J2rS+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Vw3J2rS+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0F7521F00A3D; Mon, 31 Aug 2026 12:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788179353; bh=pF4kOkSCUH1iTDUi4spzxRIPp4bQpWG7tkUadCgCnL4=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Vw3J2rS+laMQGfFMoFUIJtgUo6tMgUjqGl32F7sQVP+OzNsmzJatbCw8V2/o+bN98 Um/J3ap9cA1qWX+UVgEcjTWa8O86b7kBvEp5qVzMZ1Dz8VwMcQn8RA9We/gyWFC+rh fuscV1fqNSx0aAW8rH3K0IksR7p6YlArO7/zpzPYfkJWUQuKJZfRkMgVnZHibVANQF Y/pYN7HS9FPHxcNqn9VyqbCqJUfIEWB76svnDGhVN4i55n8B2RpOf+hPStgu26T86b 2WPUPZesnyyXf+gXSMjDpxb6LfTEFA9TKbcw9ldgn9CIO4nn+CFfaI1K9+ttmnqeUu 3s997cvwqFYlA== Message-ID: Date: Mon, 31 Aug 2026 14:29:07 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers To: Krishna Kurapati Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260828081542.52796-1-krishna.kurapati@oss.qualcomm.com> <20260831-messy-ebony-warthog-cfd727@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/08/2026 11:03, Krishna Kurapati wrote: > > > On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote: >> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote: >>> Currently for Glymur non-multiport USB controllers, number of interrupts >>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be >>> present. >>> >>> Mark glymur non-multiport controllers to support a maximum of 6 interrupts >>> including the hs_phy_irq and ss_phy_irq. >> >> Why? >> >>> >>> Signed-off-by: Krishna Kurapati >>> --- >>> Changes in v2: >>> - Modified commit text indicating the issue in max interrupt-names for >>> Glymur non-mp controllers. >>> >>> Link to v1: >>> https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/ >>> --- >>> Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml >>> index ea60f7220afe..3bef18f9557e 100644 >>> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml >>> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml >>> @@ -524,7 +524,6 @@ allOf: >>> compatible: >>> contains: >>> enum: >>> - - qcom,glymur-dwc3 >>> - qcom,milos-dwc3 >>> - qcom,x1e80100-dwc3 >>> then: >>> @@ -547,6 +546,7 @@ allOf: >>> contains: >>> enum: >>> - qcom,eliza-dwc3 >>> + - qcom,glymur-dwc3 >>> - qcom,ipq4019-dwc3 >>> - qcom,ipq8064-dwc3 >>> - qcom,kaanapali-dwc3 >> >> This changes the ABI without an explanation. >> > As per the harware specification, the controllers do have both > hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that > info. Will update the commit message accordingly. > So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was incomplete? Lack of context here is not helping. If they have these IRQs but it does not matter, then it is not a good reason to change ABI and you should just add the clock as optional to the end. Was this binding already released? I think yes. Best regards, Krzysztof