From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v1] leds: fix regression in usbport led trigger From: Jacek Anaszewski Message-Id: Date: Fri, 28 Dec 2018 17:29:56 +0100 To: Christian Lamparter , linux-usb@vger.kernel.org, linux-leds@vger.kernel.org Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Greg Kroah-Hartman List-ID: SGkgQ2hyaXN0aWFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiAxMi8yNS8xOCA5OjQ5 IFBNLCBDaHJpc3RpYW4gTGFtcGFydGVyIHdyb3RlOgo+IFRoZSBwYXRjaCAidXNiOiBzaW1wbGlm eSB1c2Jwb3J0IHRyaWdnZXIiIHRvZ2V0aGVyIHdpdGgKPiAibGVkczogdHJpZ2dlcnM6IGFkZCBk ZXZpY2UgYXR0cmlidXRlIHN1cHBvcnQiIGNhdXNlZCBhbgo+IHJlZ3Jlc3Npb24gZm9yIHRoZSB1 c2Jwb3J0IHRyaWdnZXIuIGl0IHdpbGwgbm8gbG9uZ2VyCj4gZW51bWVyYXRlIGFueSBhY3RpdmUg dXNiIGh1YiBwb3J0cyB1bmRlciB0aGUgInBvcnRzIgo+IGRpcmVjdG9yeSBpbiB0aGUgc3lzZnMg Y2xhc3MgZGlyZWN0b3J5LCBpZiB0aGUgdXNiIGhvc3QKPiBkcml2ZXJzIGFyZSBmdWxseSBpbml0 aWFsaXplZCBiZWZvcmUgdGhlIHVzYnBvcnQgdHJpZ2dlcgo+IHdhcyBsb2FkZWQuCj4gCj4gVGhl IHJlYXNvbiBpcyB0aGF0IHRoZSB1c2Jwb3J0IGRyaXZlciB0cmllcyB0byByZWdpc3Rlcgo+IHRo ZSBzeXNmcyBlbnRyaWVzIGR1cmluZyB0aGUgYWN0aXZhdGUoKSBjYWxsYmFjay4gQW5kIHRoaXMK PiB3aWxsIGZhaWwgd2l0aCAtMiAvIEVOT0VOVCBiZWNhdXNlIHRoZSBwYXRjaAo+ICJsZWRzOiB0 cmlnZ2VyczogYWRkIGRldmljZSBhdHRyaWJ1dGUgc3VwcG9ydCIgbWFkZSBpdCBzbwo+IHRoYXQg dGhlIHN5c2ZzICJwb3J0cyIgZ3JvdXAgd2FzIG9ubHkgYmVpbmcgYWRkZWQgYWZ0ZXIKPiB0aGUg YWN0aXZhdGUoKSBjYWxsYmFjayBzdWNjZWVkZWQuCj4gCj4gVGhpcyB2ZXJzaW9uIG9mIHRoZSBw YXRjaCBtb3ZlcyB0aGUgZGV2aWNlX2FkZF9ncm91cHMoKQo+IGluIGZyb250IG9mIHRoZSBjYWxs IHRvIHRoZSB0cmlnZ2VyJ3MgYWN0aXZhdGUoKSBmdW5jdGlvbgo+IGluIG9yZGVyIHRvIHNvbHZl IHRoZSBwcm9ibGVtLgo+IAo+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZv dW5kYXRpb24ub3JnPgo+IENjOiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBl bmd1dHJvbml4LmRlPgo+IENjOiBSYWZhxYIgTWnFgmVja2kgPHphamVjNUBnbWFpbC5jb20+Cj4g Rml4ZXM6IDZmN2IwYmFkODgzOSAoInVzYjogc2ltcGxpZnkgdXNicG9ydCB0cmlnZ2VyIikKPiBT aWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gTGFtcGFydGVyIDxjaHVua2VleUBnbWFpbC5jb20+Cj4g LS0tCj4gCj4gVGhpcyB2ZXJzaW9uIG9mIHRoZSBwYXRjaCAuLi4gb2Ygd2hpY2ggd2lsbCBiZSBt YW55IG1vcmU/IQo+IAo+IHllYWgsIGRldmljZV9hZGRfZ3JvdXBzKCkgaW4gZnJvbnQgb2YgYWN0 aXZhdGUoKSB3b3Jrcwo+IGZvciB0aGUgdXNicG9ydCBkcml2ZXIgc2luY2UgaXQgZHluYW1pY2Fs bHkgcmVnaXN0ZXJzCj4gdGhlIGVudHJpZXMgaW4gInBvcnRzIi4gSG93ZXZlciwgaWYgYSB0cmln Z2VyIGhhcyBhCj4gc3RhdGljIGxpc3Qgb2YgZW50aXRpZXMgdGhpcyBjYW4gZ2V0IG1vcmUgY29t cGxpY2F0ZWQsCj4gc2luY2UgSSB0aGluayB0aGUgc3lzZnMgZW50cmllcyB3aWxsIG5vdyBiZSBh dmFpbGFibGUKPiBiZWZvcmUgdGhlIGFjdGl2YXRlKCkgY2FsbCBldmVuIHN0YXJ0ZWQgYW5kIHRo aXMgY2FuCj4gZW5kIHVwIGJhZGx5LiBTbywgaXMgdGhlcmUgYW55IGJldHRlciBhcHByb2FjaD8K PiBJbnRyb2R1Y2UgYSAicG9zdF9hY3RpdmF0ZSgpIiBjYWxsYmFjaz8gT3IgdXNlIHRoZSBldmVu dAo+IHN5c3RlbSBhbmQgbWFrZSB1c2Jwb3J0IHRyaWdnZXIgb24gdGhlIEtPQkpfQ0hBTkdFPyB1 c2UKPiBhIChkZWxheWVkKSB3b3JrX3N0cnVjdCBpbiB1c2Jwb3J0IHRvIHJlZ2lzdGVyIHRoZSBw b3J0cwo+IGF0IGEgc2xpZ2h0bHkgbGF0ZXIgdGltZT8gZXRjLi4uCgpwb3N0X2FjdGl2YXRlKCkg aXMgYW4gb3B0aW9uLgoKT3RoZXJ3aXNlLCB3aXRoIHlvdXIgcGF0Y2gsIGluIG9yZGVyIHRvIHBy ZXZlbnQgYWNjZXNzIHRvIHRoZSBzeXNmcwppbnRlcmZhY2UgYmVmb3JlIHRoZSB0cmlnZ2VyIGlz IGluaXRpYWxpemVkLCB3ZSB3b3VsZCBoYXZlIHRvIGltcGxlbWVudAppc192aXNpYmxlIG9wIGZv ciBlYWNoIHN0cnVjdCBhdHRyaWJ1dGVfZ3JvdXAgaW4gdGhlIHRyaWdnZXJzCndpdGggc3RhdGlj IGF0dHJzLCBhbmQgY2hlY2sgbGVkX2NkZXYtPmFjdGl2YXRlZCB0aGVyZQooaXQgaXMgY3VycmVu dGx5IHVudXNlZCBhbmQgc2NoZWR1bGVkIGZvciByZW1vdmFsLCBidXQgd2UKd291bGQgaGF2ZSB0 byBzZXQgaXQgYWZ0ZXIgY2FsbGluZyBhY3RpdmF0ZSgpIGluIExFRCB0cmlnZ2VyIGNvcmUpLgoK SXQgd291bGQgcmVxdWlyZSBtb3JlIGVmZm9ydCBidXQgd291bGQgYWxsb3cgdG8gYXZvaWQgdGhl IGFkZGl0aW9uCm9mIGEgbmV3IG9wLiBJJ2QgYWxzbyByZW1vdmUgImFjdGl2YXRlZCIgcHJvcGVy dHkgZnJvbSBzdHJ1Y3QKbGVkX2NsYXNzZGV2IGFuZCBtYWRlIGl0IGEgZmxhZyBpbiBsZWRzLmg6 CgorI2RlZmluZSBMRURfVFJJR0dFUl9BQ1RJVkFURUQgQklUKDI0KQoKQmVzdCByZWdhcmRzLApK YWNlayBBbmFzemV3c2tpCgo+IChOb3RlOiBJJ20gaGl0dGluZyB0aGlzIG9uIDQuMTkgdG9vLCBz byB3aGF0ZXZlciB0aGUKPiByZWFsIGZpeCB3aWxsIGxvb2sgbGlrZSBpdCBzaG91bGQgYmUgYmFj a3BvcnRlZCkKPiAtLS0KPiAgIGRyaXZlcnMvbGVkcy9sZWQtdHJpZ2dlcnMuYyB8IDE5ICsrKysr KysrKystLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA5IGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2xlZHMvbGVkLXRyaWdnZXJzLmMg Yi9kcml2ZXJzL2xlZHMvbGVkLXRyaWdnZXJzLmMKPiBpbmRleCAxN2Q3M2RiMTQ1NmUuLjA4ZTdj NzI0YTlkYyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2xlZHMvbGVkLXRyaWdnZXJzLmMKPiArKysg Yi9kcml2ZXJzL2xlZHMvbGVkLXRyaWdnZXJzLmMKPiBAQCAtMTM0LDYgKzEzNCwxMiBAQCBpbnQg bGVkX3RyaWdnZXJfc2V0KHN0cnVjdCBsZWRfY2xhc3NkZXYgKmxlZF9jZGV2LCBzdHJ1Y3QgbGVk X3RyaWdnZXIgKnRyaWcpCj4gICAJCWxlZF9zZXRfYnJpZ2h0bmVzcyhsZWRfY2RldiwgTEVEX09G Rik7Cj4gICAJfQo+ICAgCWlmICh0cmlnKSB7Cj4gKwkJcmV0ID0gZGV2aWNlX2FkZF9ncm91cHMo bGVkX2NkZXYtPmRldiwgdHJpZy0+Z3JvdXBzKTsKPiArCQlpZiAocmV0KSB7Cj4gKwkJCWRldl9l cnIobGVkX2NkZXYtPmRldiwgIkZhaWxlZCB0byBhZGQgdHJpZ2dlciBhdHRyaWJ1dGVzXG4iKTsK PiArCQkJZ290byBlcnJfYWRkX2dyb3VwczsKPiArCQl9Cj4gKwo+ICAgCQl3cml0ZV9sb2NrX2ly cXNhdmUoJnRyaWctPmxlZGRldl9saXN0X2xvY2ssIGZsYWdzKTsKPiAgIAkJbGlzdF9hZGRfdGFp bCgmbGVkX2NkZXYtPnRyaWdfbGlzdCwgJnRyaWctPmxlZF9jZGV2cyk7Cj4gICAJCXdyaXRlX3Vu bG9ja19pcnFyZXN0b3JlKCZ0cmlnLT5sZWRkZXZfbGlzdF9sb2NrLCBmbGFncyk7Cj4gQEAgLTE0 NiwxMiArMTUyLDYgQEAgaW50IGxlZF90cmlnZ2VyX3NldChzdHJ1Y3QgbGVkX2NsYXNzZGV2ICps ZWRfY2Rldiwgc3RydWN0IGxlZF90cmlnZ2VyICp0cmlnKQo+ICAgCj4gICAJCWlmIChyZXQpCj4g ICAJCQlnb3RvIGVycl9hY3RpdmF0ZTsKPiAtCj4gLQkJcmV0ID0gZGV2aWNlX2FkZF9ncm91cHMo bGVkX2NkZXYtPmRldiwgdHJpZy0+Z3JvdXBzKTsKPiAtCQlpZiAocmV0KSB7Cj4gLQkJCWRldl9l cnIobGVkX2NkZXYtPmRldiwgIkZhaWxlZCB0byBhZGQgdHJpZ2dlciBhdHRyaWJ1dGVzXG4iKTsK PiAtCQkJZ290byBlcnJfYWRkX2dyb3VwczsKPiAtCQl9Cj4gICAJfQo+ICAgCj4gICAJaWYgKGV2 ZW50KSB7Cj4gQEAgLTE2NSwxNyArMTY1LDE4IEBAIGludCBsZWRfdHJpZ2dlcl9zZXQoc3RydWN0 IGxlZF9jbGFzc2RldiAqbGVkX2NkZXYsIHN0cnVjdCBsZWRfdHJpZ2dlciAqdHJpZykKPiAgIAo+ ICAgCXJldHVybiAwOwo+ICAgCj4gLWVycl9hZGRfZ3JvdXBzOgo+IC0KPiArZXJyX2FjdGl2YXRl Ogo+ICsJZGV2aWNlX3JlbW92ZV9ncm91cHMobGVkX2NkZXYtPmRldiwgdHJpZy0+Z3JvdXBzKTsK PiAgIAlpZiAodHJpZy0+ZGVhY3RpdmF0ZSkKPiAgIAkJdHJpZy0+ZGVhY3RpdmF0ZShsZWRfY2Rl dik7Cj4gLWVycl9hY3RpdmF0ZToKPiAgIAo+ICAgCWxlZF9jZGV2LT50cmlnZ2VyID0gTlVMTDsK PiAgIAlsZWRfY2Rldi0+dHJpZ2dlcl9kYXRhID0gTlVMTDsKPiAgIAl3cml0ZV9sb2NrX2lycXNh dmUoJmxlZF9jZGV2LT50cmlnZ2VyLT5sZWRkZXZfbGlzdF9sb2NrLCBmbGFncyk7Cj4gICAJbGlz dF9kZWwoJmxlZF9jZGV2LT50cmlnX2xpc3QpOwo+ICAgCXdyaXRlX3VubG9ja19pcnFyZXN0b3Jl KCZsZWRfY2Rldi0+dHJpZ2dlci0+bGVkZGV2X2xpc3RfbG9jaywgZmxhZ3MpOwo+ICsKPiArZXJy X2FkZF9ncm91cHM6Cj4gICAJbGVkX3NldF9icmlnaHRuZXNzKGxlZF9jZGV2LCBMRURfT0ZGKTsK PiAgIAo+ICAgCXJldHVybiByZXQ7Cj4K