From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C37158472 for ; Sun, 31 Mar 2024 17:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711904606; cv=none; b=DyF+hh6D02jej5UXN9Ogu/4DnS6sjsR3+iogjJgM1YXZ1hy2JDXE7n70wl/+FZXASEMS/KfBMSNU5QUC+FEVw7ZS3N/uUuq274eXWnDb7lezwd2vQiI5agrDRLPQecXPmK3XlzY3rfdztAWMmkndt9JrQqDsfWSvbwASqxMee5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711904606; c=relaxed/simple; bh=5HEKTAEcMZpIQzdxLBhC6r70+TY5nEFPngXSLpbCCms=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p8kvslG0UGoMt/fluPbsXMetDTwYGC3APE6HE4xZTGfQzml6DwWqolKM1hmAXWcjVCmsys0IHSdJV5hPztLxkDOTVbgMygxYyGeTz3X0TWZHhNhhOcP+yDh+376XGgUAr2Hc8rtc6rnUdF4Agl5s9+kpifHbM/n9XPHViocCqx8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=QhtcaSDW; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="QhtcaSDW" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-415612da358so3156845e9.0 for ; Sun, 31 Mar 2024 10:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1711904602; x=1712509402; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3uwWnHPVpblUNndWNcz6VpnPUH+KrUQEUI99rXTfFq8=; b=QhtcaSDWK1toHcsaFm/le3n317/jOqZS/3/MHqJRHTCRd62ku5cJltF9QH7WfKo+eo HDUuMjyHm4hmHAPjB0UGjOesqcghL/UY8zDSBw25qj5Fe8QEqJ9dG92W4dRuZZInEexu B1a7yV/+2obvX5zDBYfqzQ4AidjLmJPId8IMRsg94dApMkjlk05CrO8xKDrzRfb6fFYC Y45ZdZHfdnFyP9ye6Be2SRwOzL0qq9ZjtrxE2w+lgoPgU/u4GlyL3Tn8Qx2xLQl1T4TF VwXKpoKgGY3aKFNxeIi7y9yYRmRRU1o2Ntv/0sD9uY3XNgMsae6eP4yqpNw2/o2xhjod Slcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711904602; x=1712509402; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3uwWnHPVpblUNndWNcz6VpnPUH+KrUQEUI99rXTfFq8=; b=my0vKMFnZEt/S+78V2N81sF08b0UtUl/35m3TSFLzYHGmU1mZ1d5hYAasymVEwrRtY BaM/l/85s86Qdy1oDPbSA2/Q/DhJf8PCzz1h+0jjIfK0d7ihorJlfuids5HKanM13kfU k363odqsNlZWH29a8M/cHwZhfOOZxbPev+zPXYy3ydVrZ4XUhkbBydIy8XzOx0BZik6h FPwDKpDR6bGFB1HSf5xoSYSAEtGsXBCaIrkUrVlvrTM/nYlqrQeZT/r/z+ZMKMP42/nj slxgKXN7CyduOk929duhbAlQIUAfqTAbo4VaqdDLl6pWDShZCsYlDvDBUf3PSV2UZ47e 1OLw== X-Forwarded-Encrypted: i=1; AJvYcCWCXfaay4bn6bvQDXRC6kTslxL8QGB+KTbxJGXqtajZyrMv5CVk3Ol0x0BCuYX6MYQKxf4efTsYTN/rEfd2eYUzX41c0F9vSXfT X-Gm-Message-State: AOJu0Ywf90bpEtq/EhCXVKE7iznGCxKZEqgQpfqFfoRGsoCJHqJj17km N69Dn65De8KCMmvxEwjn3C18Xv5aSIe5yZZTDh8Guu5qxU9yLDXMDR8s1C8Afgk= X-Google-Smtp-Source: AGHT+IG2JDa1xRHcEDZbv+eTvKj5g66Ts2hqoZlYumJbpfHyjM2ZtfG17xOyZVT224cpD6eBDJCAgg== X-Received: by 2002:a05:600c:3502:b0:414:222:ad5e with SMTP id h2-20020a05600c350200b004140222ad5emr5730504wmq.11.1711904602142; Sun, 31 Mar 2024 10:03:22 -0700 (PDT) Received: from ?IPV6:2001:a61:1366:6801:7ce4:a9a1:7f22:a638? ([2001:a61:1366:6801:7ce4:a9a1:7f22:a638]) by smtp.gmail.com with ESMTPSA id d11-20020a05600c34cb00b004156497e973sm1098064wmq.9.2024.03.31.10.03.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 Mar 2024 10:03:21 -0700 (PDT) Message-ID: Date: Sun, 31 Mar 2024 19:03:20 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] usbnet: fix cyclical race on disconnect with work queue To: Sai Krishna Gajula , Oliver Neukum , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "syzbot+9665bf55b1c828bbcd8a@syzkaller.appspotmail.com" References: <20240321124758.6302-1-oneukum@suse.com> <04cfa214-4d45-48b1-87ba-500e3e501977@suse.com> Content-Language: en-US From: Oliver Neukum In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.03.24 14:07, Sai Krishna Gajula wrote: >>>> --- a/drivers/net/usb/usbnet.c >>>> +++ b/drivers/net/usb/usbnet.c >>>> @@ -467,10 +467,12 @@ static enum skb_state defer_bh(struct usbnet >>>> *dev, struct sk_buff *skb, void usbnet_defer_kevent (struct usbnet >>>> *dev, int work) >>> >>> space prohibited between function name and open parenthesis '(' >> >> I am sorry, but this is the context of the diff. You are not suggesting to mix >> gratitious format changes into a bug fix, are you? > > Checkpatch does a primary check and triggered warning if we use space between fn name and '('. It is advisable to follow the upstreaming process steps(clean checkpatch output) to have uniformity across patches. Also check comments from Gregkh bot regarding this patch. Hi, at the risk of repeating myself: This is a very old driver written long before these conventions. I did not introduce these spaces. Nevertheless, a format change has no place in a bug fix. Regards Oliver