From: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Wesley Cheng <wesley.cheng@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers
Date: Mon, 31 Aug 2026 14:33:21 +0530 [thread overview]
Message-ID: <ce5bf06b-8284-4355-94bb-416a8e34bd5b@oss.qualcomm.com> (raw)
In-Reply-To: <20260831-messy-ebony-warthog-cfd727@quoll>
On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>> Currently for Glymur non-multiport USB controllers, number of interrupts
>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>> present.
>>
>> Mark glymur non-multiport controllers to support a maximum of 6 interrupts
>> including the hs_phy_irq and ss_phy_irq.
>
> Why?
>
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>> Changes in v2:
>> - Modified commit text indicating the issue in max interrupt-names for
>> Glymur non-mp controllers.
>>
>> Link to v1:
>> https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/
>> ---
>> Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> index ea60f7220afe..3bef18f9557e 100644
>> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> @@ -524,7 +524,6 @@ allOf:
>> compatible:
>> contains:
>> enum:
>> - - qcom,glymur-dwc3
>> - qcom,milos-dwc3
>> - qcom,x1e80100-dwc3
>> then:
>> @@ -547,6 +546,7 @@ allOf:
>> contains:
>> enum:
>> - qcom,eliza-dwc3
>> + - qcom,glymur-dwc3
>> - qcom,ipq4019-dwc3
>> - qcom,ipq8064-dwc3
>> - qcom,kaanapali-dwc3
>
> This changes the ABI without an explanation.
>
As per the harware specification, the controllers do have both
hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
info. Will update the commit message accordingly.
Regards,
Krishna,
next prev parent reply other threads:[~2026-08-31 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 8:15 [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers Krishna Kurapati
2026-08-31 8:37 ` Krzysztof Kozlowski
2026-08-31 9:03 ` Krishna Kurapati [this message]
2026-08-31 12:29 ` Krzysztof Kozlowski
2026-09-02 14:10 ` Konrad Dybcio
2026-09-02 16:59 ` Krishna Kurapati
2026-09-03 6:32 ` Konrad Dybcio
2026-09-03 6:40 ` Krzysztof Kozlowski
2026-09-03 6:42 ` Konrad Dybcio
2026-09-03 6:41 ` Krzysztof Kozlowski
2026-09-03 8:11 ` Krishna Kurapati
2026-09-03 8:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce5bf06b-8284-4355-94bb-416a8e34bd5b@oss.qualcomm.com \
--to=krishna.kurapati@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wesley.cheng@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox