From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36BFD15DBCE for ; Mon, 27 May 2024 12:26:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716812803; cv=none; b=Z6D5Innj0K2BqjnYyOIHA9FKVbkIVoQIZ8qffLi+LJagRY86R6vYtzwb27c/TgM46dX4mw+ze2CY8R7frBUEgiAvGINS15YyfRnYdkkSpIEnQ4M3kh/ZxL1VR4UMXrXW93GpGYe6E6qkWv0QY++XgQzzZ5NTj6CHA0qEkkGDc+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716812803; c=relaxed/simple; bh=uEBh5knVxjgMQ2FRyTCSQ4x+NhsByRN32pPubCK078Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RjRMy4CM+pwmp9bhuRER910JMcF+gd1KTn//QT7mofmOzsWdiQFO3sqgq2vp+mwcOn5MnQG2rHaqbSKwj0/cCVGtbRVpjTUlRYpHLuPKFFmvzrxg55FnmLe++5bdhHzbUbDHmV+yHZRS/LXXw53Co1UvyBC0W5TZBdDj8hYxmug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=NQA7PTxb; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="NQA7PTxb" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a63036f2daaso77176266b.1 for ; Mon, 27 May 2024 05:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1716812799; x=1717417599; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+Z0jYksGWYDCzEC0W0rvVy6TJouZUOtG78WV9BnuANE=; b=NQA7PTxbCPG0ilvX5Jmqt9nVvq7Q9khn1iJbRYalCvF8/5AF3M0Vc7K5j2wDUY0Q5X bi4LLvY41IHuf1Fu5WQNOQKFlmlUHIrFucZS394h00CW8cZz6aEtwEQGBj2LBeJJXLIA zOCBJjXbVBcNzz+9QNqFkVv+b0Qmm0GuBuADFSnU2qxCRSxnTiZXUQ7GLTPFJG8c/j2F 0tTc5qGV0SpG6KuB+eGCohUSIRDiphWhEjJto/z7A6iJ+ygJrBi78zNNF6UTqiQKdMKl bS75WclvfdTksam1E4TmvTcOIKlVJlZ9BspwboQNQ4BbvrF5Lx2IuHUZEVpbwl1subnV ZZSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716812799; x=1717417599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+Z0jYksGWYDCzEC0W0rvVy6TJouZUOtG78WV9BnuANE=; b=P02fjldA/O8MRB5AWHf5gKEL6RnqNN3ane/Yy3QEANcri7GCYRTxNqIKh7snTzAkeP 2mpK62OcepYaL70ChsG85NVI4GhnuyR12p2LcZunaSDAvzaCUquIqm+8uxtBK39RnprY 9ybjwz+L4AEpWrFFcoep9qHV+5KUL9EGPmIv+nmJkUSmqc/XFoueVUBf7BPOQkh757iD /X0KfqU5CfPapfiAJipZu8LZD+IN3HbCdS2aCsVNuCnGQvbcAiKMg4Lv2Yea3CwU38UT o5aX2tJkCcbLiJ2pNxtGl2ewHKoyXlR6CVFuwOh/2p4ND4Fa7npcfq7kNlD4C0ZVpyeO WS3Q== X-Forwarded-Encrypted: i=1; AJvYcCXUzRxnuXRqC24CQY6bBtbtwG03tLCOp7RbHD+ijtOYZWumc2XMwQTeCAg3us5rkqzQWTjjKe/zTnB819xY3kGwTPq3prtgzcR4 X-Gm-Message-State: AOJu0YyBDM4q7NAJC1edZvNfuKgOdaluzXjeAfp1D/Qnp2S5XjD/J1C+ 09PouWrDyIBrE/c7OPjMzH6V305ObabN8WqyvqtDj9hbWalles+UG0rHGzuUqyk= X-Google-Smtp-Source: AGHT+IGdiAI18N5SLWq542WfS9dm3HTYqjqz0CDg1sVYs7nLcvCMNTWyAiOq78S1awvR6RQ9LsxoIA== X-Received: by 2002:a17:906:478c:b0:a5a:7a1:5d9c with SMTP id a640c23a62f3a-a6265146984mr646663766b.62.1716812799534; Mon, 27 May 2024 05:26:39 -0700 (PDT) Received: from ?IPV6:2001:a61:139b:bf01:e8eb:4d8f:8770:df82? ([2001:a61:139b:bf01:e8eb:4d8f:8770:df82]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626c817bffsm488121266b.32.2024.05.27.05.26.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 May 2024 05:26:39 -0700 (PDT) Message-ID: Date: Mon, 27 May 2024 14:26:36 +0200 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] power: supply: lenovo_yoga_c630_battery: add Lenovo C630 driver To: Dmitry Baryshkov , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Heikki Krogerus , Greg Kroah-Hartman , Konrad Dybcio Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, Nikita Travkin References: <20240527-yoga-ec-driver-v3-0-327a9851dad5@linaro.org> <20240527-yoga-ec-driver-v3-4-327a9851dad5@linaro.org> Content-Language: en-US From: Oliver Neukum In-Reply-To: <20240527-yoga-ec-driver-v3-4-327a9851dad5@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27.05.24 12:03, Dmitry Baryshkov wrote: Hi, > +struct yoga_c630_psy { > + struct yoga_c630_ec *ec; > + struct device *dev; > + struct device_node *of_node; > + struct notifier_block nb; > + struct mutex lock; > + > + struct power_supply *adp_psy; > + struct power_supply *bat_psy; > + > + unsigned long last_status_update; > + > + bool adapter_online; > + > + bool unit_mA; > + > + unsigned int scale; why do you store unit_mA and scale? This looks redundant and like a source of confusion to me. Regards Oliver