From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: dwc3: of-simple: fix use-after-free on remove From: Roger Quadros Message-Id: Date: Mon, 18 Jun 2018 17:32:03 +0300 To: Felipe Balbi , Johan Hovold , Tero Kristo Cc: Greg Kroah-Hartman , Alan Stern , linux-usb@vger.kernel.org, "Nori, Sekhar" , Grygorii Strashko , Tony Lindgren , Nishanth Menon List-ID: K1Rlcm8sIFRvbnkgYW5kIHNvbWUgVEkgZm9sa3MKCk9uIDE4LzA2LzE4IDE1OjIxLCBGZWxpcGUg QmFsYmkgd3JvdGU6Cj4gCj4gSGksCj4gCj4gUm9nZXIgUXVhZHJvcyA8cm9nZXJxQHRpLmNvbT4g d3JpdGVzOgo+PiBPbiAxOC8wNi8xOCAxMjo1MSwgRmVsaXBlIEJhbGJpIHdyb3RlOgo+Pj4KPj4+ IEhpLAo+Pj4KPj4+IEpvaGFuIEhvdm9sZCA8am9oYW5Aa2VybmVsLm9yZz4gd3JpdGVzOgo+Pj4+ IE9uIE1vbiwgSnVuIDE4LCAyMDE4IGF0IDEyOjMzOjQ0UE0gKzAzMDAsIEZlbGlwZSBCYWxiaSB3 cm90ZToKPj4+Pgo+Pj4+PiBKb2hhbiBIb3ZvbGQgPGpvaGFuQGtlcm5lbC5vcmc+IHdyaXRlczoK Pj4+Pgo+Pj4+Pj4gSSBzdWdnZXN0IG1lcmdpbmcgdGhpcyBmaXggZm9yIDQuMTgtcmMsIGFuZCB0 aGVuIFJvZ2VyIGNhbiByZXdvcmsgdGhlCj4+Pj4+PiBkcml2ZXIgc28gdGhhdCBpdCB3b3JrcyBh bHNvIG9uIE9NQVAuCj4+Pj4+Cj4+Pj4+IG9tYXAgaGFzIGl0cyBvd24gZ2x1ZSBsYXllciBmb3Ig c2V2ZXJhbCByZWFzb25zLiBJZiB5b3UncmUgdGFsa2luZyBhYm91dAo+Pj4+PiBLZXlzdG9uZSBk ZXZpY2VzLCB0aGVuIG9rYXksIEkgdW5kZXJzdGFuZC4gQnV0IGluIHRoYXQgY2FzZSwgdGhpcyB3 b3VsZAo+Pj4+PiBtZWFuIEtleXN0b25lIGlzIGNvcHlpbmcgdGhlIHNhbWUgYXJndWFibHkgYnJv a2VuIFBNIGRvbWFpbiBkZXNpZ24gZnJvbQo+Pj4+PiBPTUFQIGFuZCBpdCB3b3VsZCBiZSBiZXN0 IG5vdCB0byBwcm9wYWdhdGUgdGhhdCBpZGVhLgo+Pj4+Cj4+Pj4gTWF5YmUgc28uIEknbSBub3Qg c3VyZSB3aGF0IFJvZ2VyJ3MgdXNlIGNhc2UgaXMsIGJ1dCBwZXJoYXBzIHRoZSBvbWFwCj4+Pj4g Z2x1ZSBkcml2ZXIgY291bGQgYmUgdXNlZCBpbnN0ZWFkLgo+Pj4KPj4+IHVubGlrZWx5LiBLZXlz dG9uZSBkZXZpY2VzIGFyZSB2ZXJ5IGRpZmZlcmVudCBmcm9tIE9NQVAgZmFtaWx5LiBCdXQKPj4+ IHdlJ2xsIHNlZSB3aGF0IFJvZ2VyIHNheXMuCj4+Pgo+Pgo+PiBXZWxsLCBJIHdhcyBjb25zaWRl cmluZyB0byB1c2Ugb2Ytc2ltcGxlIGZvciB0aGUgQU02NTQgU29DIFsxXSBidXQgbm93Cj4+IEkn bSBvZiB0aGUgb3BpbmlvbiB0aGF0IGl0IG1pZ2h0IGJlIGJldHRlciB0byBhZGQgYSBuZXcgZ2x1 ZSBsYXllciBkcml2ZXIKPiAKPiB3aHkgaXNuJ3QgZHdjMy1rZXlzdG9uZS5jIGVub3VnaD8KCkl0 IGlzIGRvaW5nIHRvbyBtYW55IHRoaW5ncyB0aGFuIHdlIHJlYWxseSBuZWVkIHRvIGZvciBBTTY1 NC4KCj4gCj4+IGZvciB0aGF0IGJlY2F1c2UKPj4gLSBpdCBuZWVkcyB0byBwb2tlIGEgZmV3IHJl Z2lzdGVycyBpbiB0aGUgd3JhcHBlciByZWdpb24KPiAKPiBkd2MzLWtleXN0b25lLmMgZG9lcyB0 aGF0IGFscmVhZHkKPiAKPj4gLSBpdCBkb2Vzbid0IHJlYWxseSBuZWVkIHRoZSBkcml2ZXIgdG8g ZW5hYmxlIGFueSBjbG9jawo+IAo+IFNlZW1zIHRvIG1lIHlvdSdyZSB0cnlpbmcgdG8gcG9ydCBv bWFwX2RldmljZSB0byBhcm02NC4uLgoKSXQgaXNuJ3QgYW4gb21hcF9kZXZpY2UgYnV0IGlzIHZl cnkgc2ltaWxhciB0byBob3cgaXQgaXMgZG9uZSBvbiBrZXlzdG9uZS4KCj4gCj4+IC0gaXQgbmVl ZHMgYSBwbV9ydW50aW1lX2dldF9zeW5jKCkgdG8gYmUgZG9uZSBpbiBwcm9iZQo+IAo+IHRoaXMg cmVhbGx5IHNob3VsZG4ndCBiZSBuZWNlc3NhcnkuIEtleXN0b25lIGRvZXNuJ3QgcmVseSBvbiBh bGwgdGhlCj4gb21hcF9kZXZpY2UgbGVnYWN5LiBBdCBsZWFzdCBpdCBkaWRuJ3QgdXNlIHRvLiBD b3VsZCBpdCBiZSB0aGF0IHlvdSdyZQo+IGp1c3QgbWlzc2luZyBhIHN0cnVjdCBkZXZfcG1fZG9t YWluIGRlZmluaXRpb24gZm9yIGFybTY0PwoKSSBkb24ndCB0aGluayBzby4gSWYgSSBoYWQgbWlz c2VkIGl0IGl0IHdvdWxkbid0IGVuYWJsZSBhdCBhbGwuCgo+IAo+IEkgaGF2ZW4ndCBzZWVuIGhv dyB5b3UgZ3V5cyBpbXBsZW1lbnRlZCB5b3VyIFBNIGZvciBhcm02NCAoaXMgdGhlcmUgYQo+IHB1 YmxpY2FsbHkgYWNjZXNzaWJsZSB2ZXJzaW9uIHNvbWV3aGVyZT8pLCBidXQgSSdkIHNheSB5b3Ug c2hvdWxkIHRha2UKPiB0aGUgb3Bwb3J0dW5pdHkgdG8gcmVtb3ZlIHRoaXMgcmVseWluZyBvbiBw bV9ydW50aW1lX2dldF9zeW5jKCkgY2FsbHMKPiBmcm9tIHByb2JlIGFuZCBqdXN0IGRvIHdoYXQg ZXZlcnlib2R5IGVsc2UgZG9lczsgbmFtZWx5OiBlbmFibGUgY2xvY2tzCj4gb24gcHJvYmUsIHBt X3J1bnRpbWVfc2V0X2FjdGl2ZSwgZXRjLgoKVGhpcyBpcyBzb21ldGhpbmcgVGVybyBjYW4gY29t bWVudCBvbi4KCj4gCj4gVGhpcyBoZWxwcyBkcml2ZXJzIGJlaW5nIGFibGUgdG8gbWFrZSBhc3N1 bXB0aW9ucyBhYm91dCBkZXZpY2VzIGJlaW5nCj4gZW5hYmxlZCBkdXJpbmcgcHJvYmUuIHBtX3J1 bnRpbWUgYmVjb21lcyBlYXNpZXIgdG8gaW1wbGVtZW50IGdlbmVyaWNhbGx5Cj4gdG9vLgo+IAoK WW91IGtlZXAgbWVudGlvbmluZyB0aGF0IFBNIGRvbWFpbiBkZXNpZ24gaXMgYnJva2VuIG9uIE9N QVAuCkNvdWxkIHlvdSBwbGVhc2UgY2xhcmlmeSB3aGF0IGlzIGJyb2tlbj8gSXMgaXQgdGhlIGZh Y3QgdGhhdCB0aGUgYnVzIGNvZGUKZG9lc24ndCBlbmFibGUgdGhlIGRldmljZSBiZWZvcmUgcHJv YmUgYW5kIHRoYXQgd2UgaGF2ZSB0byBkbyBhIHBtX3J1bnRpbWVfc3luYygpIGluIHByb2JlPwoK SSB0cmllZCB0byBkaXNjdXNzIHRoaXMgaGVyZSBbMV0gYnV0IGxvb2tzIGxpa2UgeW91IG1pc3Nl ZCBpdC4KClJlLWl0ZXJhdGluZyBoZXJlLgoKUGxhdGZvcm0gYnVzIGRvZXNuJ3Qgc2VlbSB0byBl bmFibGUgdGhlIGRldmljZSBhcyBwYXJ0IG9mIG9mX3BsYXRmb3JtX3BvcHVsYXRlKCkuCgpzZWUg X19kZXZpY2VfYXR0YWNoKCkgYW5kIGRyaXZlcl9wcm9iZV9kZXZpY2UoKSBpbiBkcml2ZXJzL2Jh c2UvZGQuYwoKSXQgZG9lcyBhIHBtX3J1bnRpbWVfZ2V0X3N5bmMoKSBvbiBkZXYtPnBhcmVudCBi dXQgbm90IG9uIGRldi4KCkFsc28sIGZyb20gc2VjdGlvbiA1IG9mIERvY3VtZW50YXRpb24vcG93 ZXIvcnVudGltZV9wbS50eHQKCiJJbiBhZGRpdGlvbiB0byB0aGF0LCB0aGUgaW5pdGlhbCBydW50 aW1lIFBNIHN0YXR1cyBvZiBhbGwgZGV2aWNlcyBpcwonc3VzcGVuZGVkJywgYnV0IGl0IG5lZWQg bm90IHJlZmxlY3QgdGhlIGFjdHVhbCBwaHlzaWNhbCBzdGF0ZSBvZiB0aGUgZGV2aWNlLgpUaHVz LCBpZiB0aGUgZGV2aWNlIGlzIGluaXRpYWxseSBhY3RpdmUgKGkuZS4gaXQgaXMgYWJsZSB0byBw cm9jZXNzIEkvTyksIGl0cwpydW50aW1lIFBNIHN0YXR1cyBtdXN0IGJlIGNoYW5nZWQgdG8gJ2Fj dGl2ZScsIHdpdGggdGhlIGhlbHAgb2YKcG1fcnVudGltZV9zZXRfYWN0aXZlKCksIGJlZm9yZSBw bV9ydW50aW1lX2VuYWJsZSgpIGlzIGNhbGxlZCBmb3IgdGhlIGRldmljZS4iCgoiTm90ZSwgaWYg dGhlIGRldmljZSBtYXkgZXhlY3V0ZSBwbV9ydW50aW1lIGNhbGxzIGR1cmluZyB0aGUgcHJvYmUg KHN1Y2ggYXMKaWYgaXQgaXMgcmVnaXN0ZXJzIHdpdGggYSBzdWJzeXN0ZW0gdGhhdCBtYXkgY2Fs bCBiYWNrIGluKSB0aGVuIHRoZQpwbV9ydW50aW1lX2dldF9zeW5jKCkgY2FsbCBwYWlyZWQgd2l0 aCBhIHBtX3J1bnRpbWVfcHV0KCkgY2FsbCB3aWxsIGJlCmFwcHJvcHJpYXRlIHRvIGVuc3VyZSB0 aGF0IHRoZSBkZXZpY2UgaXMgbm90IHB1dCBiYWNrIHRvIHNsZWVwIGR1cmluZyB0aGUKcHJvYmUu IFRoaXMgY2FuIGhhcHBlbiB3aXRoIHN5c3RlbXMgc3VjaCBhcyB0aGUgbmV0d29yayBkZXZpY2Ug bGF5ZXIuIgoKU28gbG9va3MgbGlrZSB3ZSBjYW4ndCBhc3N1bWUgdGhhdCB0aGUgZGV2aWNlIGlz ICJhY3RpdmUiIHdoZW4gcHJvYmUoKSBpcyBjYWxsZWQuCldoaWNoIG1lYW5zLCB3ZSBuZWVkIHRv IGRvCgpwbV9ydW50aW1lX2dldF9zeW5jKCk7CmVuYWJsZSBvcHRpb25hbCBjbG9ja3M7CgoKWzFd IGh0dHBzOi8vbGttbC5vcmcvbGttbC8yMDE4LzYvMTMvMjY1Cg==