linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Niklas Neronin <niklas.neronin@linux.intel.com>,
	linux-usb@vger.kernel.org
Cc: mathias.nyman@linux.intel.com, heikki.krogerus@linux.intel.com,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH] usb: common: add driver for USB Billboard devices
Date: Mon, 12 Feb 2024 15:16:53 +0100	[thread overview]
Message-ID: <cf529310-233a-466d-ade8-e0de4e20a794@suse.com> (raw)
In-Reply-To: <20240206125623.1208161-1-niklas.neronin@linux.intel.com>

On 06.02.24 13:56, Niklas Neronin wrote:

Hi,

this part should be part of uapi regardless what
you think about the rest of the driver.
Could you make a patch for that?

	Regards
		Oliver

> +
> +/* Struct for Billboard Capability Descriptor */
> +struct usb_billboard_cap_descriptor {
> +	__u8	bLength;
> +	__u8	bDescriptorType;
> +	__u8	bDevCapabilityType;
> +	__u8	iAddtionalInfoURL;
> +	__u8	bNumberOfAlternateOrUSB4Modes;
> +	__u8	bPreferredAlternateOrUSB4Modes;
> +	__le16	VCONNPower;
> +	__u8	bmConfigured[32];
> +	__u8	bvdVersion[2];
> +	__u8	bAdditionalFailureInfo;
> +	__u8	bReserved;
> +	DECLARE_FLEX_ARRAY(struct {
> +		__le16	wSVID;
> +		__u8	bAlternateOrUSB4Mode;
> +		__u8	iAlternateOrUSB4ModeString;
> +	}, aum) __packed;
> +} __packed;
> +
> +/* Struct for Billboard AUM Capability Descriptor */
> +struct usb_billboard_aum_cap_descriptor {
> +	__u8	bLength;
> +	__u8	bDescriptorType;
> +	__u8	bDevCapabilityType;
> +	__u8	bIndex;
> +	__le32	bwAlternateModesVdo;
> +} __packed;

  parent reply	other threads:[~2024-02-12 14:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06 12:56 [PATCH] usb: common: add driver for USB Billboard devices Niklas Neronin
2024-02-06 14:47 ` Greg KH
2024-02-06 15:31   ` Heikki Krogerus
2024-02-07  9:46     ` Greg KH
2024-02-07  7:48   ` Mathias Nyman
2024-02-07 10:51   ` Neronin, Niklas
2024-02-12 14:16 ` Oliver Neukum [this message]
2024-02-13  8:06   ` Neronin, Niklas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf529310-233a-466d-ade8-e0de4e20a794@suse.com \
    --to=oneukum@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    --cc=niklas.neronin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).