From: Oliver Neukum <oneukum@suse.com>
To: Juhyung Park <qkrwngud825@gmail.com>, Oliver Neukum <oneukum@suse.com>
Cc: 曾红玲 <zenghongling@kylinos.cn>,
linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net,
gregkh <gregkh@linuxfoundation.org>,
stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] Revert "usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS"
Date: Tue, 17 Jan 2023 09:34:34 +0100 [thread overview]
Message-ID: <d01fed62-dacd-b3a8-c138-73f6093f58ff@suse.com> (raw)
In-Reply-To: <CAD14+f3nHd3tSFwfpLkFfQOAAg8w9soRTf7F53Bj_UsCmN9+ow@mail.gmail.com>
On 17.01.23 09:18, Juhyung Park wrote:
Hi,
> I'm not sure if this is worthy enough to write in the commit message,
> let me know what you think.
> Maybe link the relevant lore.kernel.org discussions directly into the
> commit message?
By any means. The patch is the best you can do. I see and appreciate it.
It is still ugly. Yet, if there is no better way, so be it. But this
needs an extensive justification in the change log.
Please rather be wordier than you think necessary than too short.
I'll ack it.
Regards
Oliver
next prev parent reply other threads:[~2023-01-17 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2mw02fh6hzd-2mw3w8xfngq@nsmail7.0.0--kylin--1>
[not found] ` <CAD14+f1p3j3WJUYshneH7A38b8JsiXjtScESB2uOQ-ZyBi57tg@mail.gmail.com>
2023-01-10 5:37 ` Re: [PATCH] Revert "usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS" Juhyung Park
2023-01-17 6:16 ` Juhyung Park
2023-01-17 8:09 ` Oliver Neukum
2023-01-17 8:18 ` Juhyung Park
2023-01-17 8:34 ` Oliver Neukum [this message]
2023-01-17 9:00 ` Juhyung Park
2023-01-09 11:55 Juhyung Park
2023-01-09 12:02 ` Oliver Neukum
2023-01-09 12:16 ` Juhyung Park
2023-01-09 15:48 ` Alan Stern
2023-01-10 5:24 ` Juhyung Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01fed62-dacd-b3a8-c138-73f6093f58ff@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=qkrwngud825@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=zenghongling@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox