linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thierry Reding <treding@nvidia.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: phy: tegra: select USB_COMMON
Date: Thu, 31 May 2018 01:12:52 +0300	[thread overview]
Message-ID: <d06a612f-1519-40cd-a912-e45df408c178@gmail.com> (raw)

On 31.05.2018 00:33, Arnd Bergmann wrote:
> A built-in PHY driver cannot link against modular USB core code:
> 
> drivers/usb/phy/phy-tegra-usb.o: In function `tegra_usb_phy_probe':
> phy-tegra-usb.c:(.text+0x6bc): undefined reference to `usb_get_dr_mode'
> 
> This uses a 'select' statement in Kconfig like we have for other such
> PHY drivers.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/usb/phy/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/phy/Kconfig b/drivers/usb/phy/Kconfig
> index b9b0a44be679..d7312eed6088 100644
> --- a/drivers/usb/phy/Kconfig
> +++ b/drivers/usb/phy/Kconfig
> @@ -162,6 +162,7 @@ config USB_MXS_PHY
>  config USB_TEGRA_PHY
>  	tristate "NVIDIA Tegra USB PHY Driver"
>  	depends on ARCH_TEGRA
> +	select USB_COMMON
>  	select USB_PHY
>  	select USB_ULPI
>  	help
> 

Thank you!

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-05-30 22:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-30 22:12 Dmitry Osipenko [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-30 21:33 phy: tegra: select USB_COMMON Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d06a612f-1519-40cd-a912-e45df408c178@gmail.com \
    --to=digetx@gmail.com \
    --cc=arnd@arndb.de \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).