From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F3B1E505 for ; Fri, 7 Mar 2025 22:30:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741386658; cv=none; b=K8Q++ii6ybtTVvwHhhS1fSBdsAiM6WhT4YntDX2xt2KOj00WcqZBWOXLbKNjoj6lcOfTdvGlBGq/1hnpQgIW2FmbahFJeT30bdK9bGZICDyga5uJ8ntpCfnNTv5y6iW71OefnvLQXpn8kCbvzTgJAsN9UCHSzqEuy3h2DvoKrvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741386658; c=relaxed/simple; bh=bCNAocCazVKoVFzq/ND5cjZiWr84ZC7bmNadsW1yn9E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=P0LE/aO8qSzj3fog1PDasf1SMYwgjbm7OHt4vcRRbeS8rlHezGukY7x0bzzjUpY6HM8YHcmXBhdPJwzVV8QGE/tEHXAZzPYIjQr8n5mCPzZFgvzzfFN6xCn5iw96uMZKB8llo6L4H4kr6Kzg/0jlOUJVxfc1DyrI7vzrEbn700c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=lGGTuGf1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="lGGTuGf1" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 527LGXWH019246 for ; Fri, 7 Mar 2025 22:30:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ak5fxQibEzWrpDH5Ilc3caDZL5F6Fyf98J8EyekNGds=; b=lGGTuGf1QBsFhqug y+AEq/fVLBCpxKJm3ESO4Rvq2CZtwXrkJuhtDQdP0pG5sS8ajLzMcRwILll9t9yg YoSWcjftY1G5rPqvIyCFWFVmHWwAq2GQXewt+gwjSrtKe03ehTw7LGxnw+YOzhV5 DpDYXs4DaTqJH8EJPqbzUvsTWsNVxgt2uy+L2REzy9LZhdYN5W+o/42CcKxuRBX/ 1CIMD98qNhDLmvwELoICplAHgIIc8XEGTrUkBPPD/yyrynfAw2jIKwoaUd0b9AP7 ZaelTsOEIe8u8wG9VI60tKaeb+cqTJktAZDh5E7GbF1CegKbFe7cbhvr5iLmovMO KsRB6g== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4588jq03fu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 07 Mar 2025 22:30:48 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6e8fd4ef023so4303526d6.2 for ; Fri, 07 Mar 2025 14:30:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741386647; x=1741991447; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ak5fxQibEzWrpDH5Ilc3caDZL5F6Fyf98J8EyekNGds=; b=X9VgyGpyySFCwtSo1+LbpJZrVLi0yrISYMwuTD0H8w+8GLKbMwHN3biv+VZT9TUyDM E6+9ULYo3pfGPUDPVypBFDHp4Grs00lMkKW0HYsdolOABqmsltnBEaWdSuXmQN5IR4PA V4nZW/9K6esbmC2r06b7GNfrCOIrcFkSdfJeOGt2sPKry4UcbvviElELRufXDSG2nHfK msovIYPajNN0Ew6+iTuQswd9YhugnXHxJLnZchYUKuHvKADrRqF3U8OSHJeLx0+nXKUa gnRQSleEY+s0eraURnRd5CycVWJpeYeJZQsK6wIOBImNki3MLgto1/WWXZ96fxnf6TYV Gt+Q== X-Forwarded-Encrypted: i=1; AJvYcCUt8pJCJA5LgZpDWqamd6+O3Ohd8Z2LXIBA07KZAmlqr7o9wmeJKTuDGmyUE5+SUb3GIQd8WFLKg0c=@vger.kernel.org X-Gm-Message-State: AOJu0YyIy0wCX2/2VI+dof1ip2DMcfSuR3nOeyx5SyngpY+hd8kFDicS +cuIA8gW3HGPERSfc75gjy6vrf7v0xJgxwqCLGX1SvP1Or2+emf7VgF9MBW7hZRysTkuoWnqtG3 aji84JjUe447LCTT0ObPb3FiWatdx21gjahImipyFDQU5q/EImrltyd1EVVU= X-Gm-Gg: ASbGncvfA+8I911chF6le2PbI8zIv2WtaCDidCLUxH7snDJyz9OtaZLiW2vC59JL+kC WkocW6/STwP8oHE/JKOO6QWKYREz2AZ0hdUtj3j3ig6j1wluHEMv1OBlhiC/NIlKJQCAmUS1uam oW8BCqr7gtNd/uQPpLCETu2FIHYrI3PQi+LvWdK/mMZjEOwhuwKpxpf081NqxiIMNNGKZn/tzPY ldvzxDhppEmKdZXShzoDzHyG6sTMvFrRcHTZRIC9VDTJvWzQVjxs0MJ4KV4499MrBLmyxu/JGav KEczMdF9pbsQuA1n0/Z2LP5ICBHnigZLsePoYHPa6rPSHPTwZ4v9HegVveraHLkUBW6nkw== X-Received: by 2002:a05:6214:ac1:b0:6e8:f645:2639 with SMTP id 6a1803df08f44-6e908cd150fmr4825236d6.5.1741386647149; Fri, 07 Mar 2025 14:30:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IHiC4koxcJVdaUrklQtVOopVLiy0hknFp7oOAgVhzdT3gbIZwIK648n2T72jt6jEmVlQvFqKQ== X-Received: by 2002:a05:6214:ac1:b0:6e8:f645:2639 with SMTP id 6a1803df08f44-6e908cd150fmr4824846d6.5.1741386646742; Fri, 07 Mar 2025 14:30:46 -0800 (PST) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5e5c74a6af7sm3083132a12.33.2025.03.07.14.30.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Mar 2025 14:30:46 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2025 23:30:40 +0100 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/11] dt-bindings: power: qcom,kpss-acc-v2: Add MSM8916 compatible To: Stephan Gerhold , Konrad Dybcio Cc: Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Robert Foss , Greg Kroah-Hartman , Wesley Cheng , Christian Marangi , Bjorn Andersson , Rohit Agarwal , Kyle Deng , Vinod Koul , Marijn Suijten , linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Krzysztof Kozlowski , linux-usb@vger.kernel.org, Konrad Dybcio References: <20250306-topic-dt_bindings_fixups-v1-0-0c84aceb0ef9@oss.qualcomm.com> <20250306-topic-dt_bindings_fixups-v1-3-0c84aceb0ef9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: YK6e5L7CZvqout_P_gVoITHdtk8r-6nb X-Authority-Analysis: v=2.4 cv=Qv+k3Uyd c=1 sm=1 tr=0 ts=67cb7398 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Vs1iUdzkB0EA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=2aLQLXHzPMxx44zPxJMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: YK6e5L7CZvqout_P_gVoITHdtk8r-6nb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-07_08,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 impostorscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 priorityscore=1501 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503070170 On 7.03.2025 12:07 PM, Stephan Gerhold wrote: > On Thu, Mar 06, 2025 at 07:11:15PM +0100, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> MSM8916 seems to reuse the same hardware as MSM8974 and friends (for >> whom this binding document was created). Add a new compatible for it. >> >> Signed-off-by: Konrad Dybcio >> --- >> Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> index 202a5d51ee88c7190805efe8f1bf493bdb69ec45..27dae49163fa0790ceb6fda8a5c674f739d4a41a 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> +++ b/Documentation/devicetree/bindings/power/qcom,kpss-acc-v2.yaml >> @@ -18,7 +18,9 @@ description: >> >> properties: >> compatible: >> - const: qcom,kpss-acc-v2 >> + enum: >> + - qcom,msm8916-kpss-acc > > Hm, MSM8916 doesn't have a *K*PSS (Krait Processor SubSystem), it has an > *A*PSS (ARM Cortex – A53 SubSystem, or Application Processor SubSystem). You would think that, but actually it's still called KPSS internally.. > > I think this should be either qcom,msm8916-apss-acc, or you just keep > the qcom,msm8916-acc we already use. I'm guessing ACC stands for > "Application Clock Controller", so it would be unique enough already. > > There is actually a patch from Rayyan already with a R-b from Krzysztof. > Maybe you, or whoever is responsible, can pick it up? > > https://lore.kernel.org/linux-arm-msm/20240710155226.130086-1-rayyan.ansari@linaro.org/ I'm not opposed to this either Looks like Sebastian Reichel and/or Ulf pick up power dt-bindings patches Konrad