From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Eugeniu Rosca <erosca@de.adit-jv.com>,
Hardik Gajjar <hgajjar@de.adit-jv.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Oliver Neukum <oneukum@suse.com>
Subject: Re: [PATCH v2 3/8] usb: core: hub: Print speed name based on ssp rate
Date: Thu, 11 Mar 2021 03:46:10 +0000 [thread overview]
Message-ID: <d134c2fb-9bed-cd4f-fb9d-24b0aac4b510@synopsys.com> (raw)
In-Reply-To: <dca3aff0-793f-394b-1ded-47140f0c8a30@linux.intel.com>
Mathias Nyman wrote:
> On 4.2.2021 6.10, Thinh Nguyen wrote:
>> Check for usb_device->ssp_rate to print the SuperSpeed Plus signaling
>> rate generation and lane count.
>>
>> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
>> ---
>> Changes in v2:
>> - None
>>
>> drivers/usb/core/hub.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
>> index 823470607d58..6dc4e7385e75 100644
>> --- a/drivers/usb/core/hub.c
>> +++ b/drivers/usb/core/hub.c
>> @@ -4830,9 +4830,13 @@ hub_port_init(struct usb_hub *hub, struct usb_device *udev, int port1,
>> "%s SuperSpeed%s%s USB device number %d using %s\n",
>> (udev->config) ? "reset" : "new",
>> (udev->speed == USB_SPEED_SUPER_PLUS) ?
>> - "Plus Gen 2" : " Gen 1",
>> - (udev->rx_lanes == 2 && udev->tx_lanes == 2) ?
>> - "x2" : "",
>> + " Plus" : "",
>> + (udev->ssp_rate == USB_SSP_GEN_2x2) ?
>> + " gen2x2" :
>> + (udev->ssp_rate == USB_SSP_GEN_2x1) ?
>> + " gen2x1" :
>> + (udev->ssp_rate == USB_SSP_GEN_1x2) ?
>> + " gen1x2" : "",
> Minor nit:
> Should we keep the "Gen XxY" format used in spec and driver, instead of this "genXxY"
>
Ok. I've made the fix.
Thanks,
Thinh
next prev parent reply other threads:[~2021-03-11 3:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 4:10 [PATCH v2 0/8] usb: Check for genXxY on host Thinh Nguyen
2021-02-04 4:10 ` [PATCH v2 1/8] usb: core: Track SuperSpeed Plus GenXxY Thinh Nguyen
2021-02-04 4:10 ` [PATCH v2 2/8] usb: core: hub: Remove port_speed_is_ssp() Thinh Nguyen
2021-02-04 4:10 ` [PATCH v2 3/8] usb: core: hub: Print speed name based on ssp rate Thinh Nguyen
2021-03-10 8:37 ` Mathias Nyman
2021-03-11 3:46 ` Thinh Nguyen [this message]
2021-02-04 4:10 ` [PATCH v2 4/8] usb: core: sysfs: Check for SSP rate in speed attr Thinh Nguyen
2021-02-04 4:11 ` [PATCH v2 5/8] usb: xhci: Init root hub SSP rate Thinh Nguyen
2021-02-04 4:11 ` [PATCH v2 6/8] usb: xhci: Fix port minor revision Thinh Nguyen
2021-02-04 4:11 ` [PATCH v2 7/8] usb: xhci: Rewrite xhci_create_usb3_bos_desc() Thinh Nguyen
2021-03-09 11:47 ` Mathias Nyman
2021-03-09 19:32 ` Thinh Nguyen
2021-03-10 8:28 ` Mathias Nyman
2021-02-04 4:11 ` [PATCH v2 8/8] usb: xhci: Remove unused function Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d134c2fb-9bed-cd4f-fb9d-24b0aac4b510@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=erosca@de.adit-jv.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=hgajjar@de.adit-jv.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).