From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Oliver Neukum <oneukum@suse.com>, linux-usb@vger.kernel.org
Cc: linux-doc@vger.kernel.org, tytso@mit.edu,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: proposal to delete the skeleton driver
Date: Wed, 8 Dec 2021 19:13:58 +0100 [thread overview]
Message-ID: <d1797628-9782-ba76-9eff-f400f9aa2446@gmail.com> (raw)
In-Reply-To: <df5bb0a6-e5f5-e062-5c02-e1de612058e2@suse.com>
On 12/7/21 11:16 AM, Oliver Neukum wrote:
> Hi,
>
> it seems to me that the method of maintaining an example driver
> does not work because it will inevitably be
>
> * untested
>
> * out of date
>
> Thus our documentation would be improved by replacing its examples
> with code from drivers for real hardware. Such code wouldn't be pretty
> or written for text books, but it would be tested.
> I could do it this week in a first proposal. But I don't want to start
> if somebody feels that the skeleton driver absolutely has to stay.
>
> Regards
>
> Oliver
>
My wish is that it is only deleted when you have something similar as
proposed by Ted.
I have tested the driver during the last three month. I used different
devices. The best one was a USB to serial adapter, as it has the by the
driver expected bulk in and out endpoints. In the skel_open() I was
putting in an initialization and was able to set RTS and other signals
on the RS232 side. I was also able to test the usb_bulk_msg() receiving
example for my patch…
I truly believe that it has issues. But it is usable.
I liked that it is a character device and that it is one file and not
distributed among many files.
Regards
Philipp
prev parent reply other threads:[~2021-12-08 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 10:16 proposal to delete the skeleton driver Oliver Neukum
2021-12-07 10:24 ` Greg KH
2021-12-07 22:43 ` Theodore Y. Ts'o
2021-12-08 11:13 ` Oliver Neukum
2021-12-11 16:28 ` Philipp Hortmann
2021-12-08 18:13 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1797628-9782-ba76-9eff-f400f9aa2446@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox