public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: Oliver Neukum <oneukum@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Peter Hutterer <peter.hutterer@who-t.net>,
	linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [RFC v1] USB: core: add USBDEVFS_REVOKE ioctl
Date: Thu, 28 Apr 2022 13:21:54 +0200	[thread overview]
Message-ID: <d4c72d3d8d25f25bd12cdfbf3e7efe3ea1c3f0a7.camel@hadess.net> (raw)
In-Reply-To: <fbc988f7-5cd3-2ac8-12cc-f09ae005247d@suse.com>

On Thu, 2022-04-28 at 12:28 +0200, Oliver Neukum wrote:
> 
> 
> On 26.04.22 12:37, Bastien Nocera wrote:
> > 
> > I don't think anyone wants to implement path based syscalls,
> > and again,
> > it's equivalent to remote closing the fd, not to disabling the
> > access
> > to the device:
> > "If the file is a special file for a device which is open, the
> > device
> > close function is called as if all open references to the file had
> > been
> > closed."
> OK, so do we still have a need to discuss this specifically to usbfs?
> I suppose if you put this into VFS, you will need a hook to map the
> syscall to drivers that need to handling ioctl() having effects
> beyond
> their syscall abstractly speaking.

I'm afraid that I don't have any intentions on working on this feature
at the vfs level. As I already mentioned, I think that the semantics
are too different to make sense at that level.

I'm instead investigating having an ioctl-less BPF interface, with the
help of Benjamin and Peter.

  reply	other threads:[~2022-04-28 11:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 13:23 [RFC v1] USB: core: add USBDEVFS_REVOKE ioctl Bastien Nocera
2022-04-25 13:28 ` Bastien Nocera
2022-04-25 13:49 ` Oliver Neukum
2022-04-25 14:25   ` Bastien Nocera
2022-04-25 14:45   ` Bastien Nocera
2022-04-25 14:10 ` Greg Kroah-Hartman
2022-04-25 14:28   ` Bastien Nocera
2022-04-25 15:00     ` Greg Kroah-Hartman
2022-04-25 15:17       ` Bastien Nocera
2022-04-25 15:45         ` Greg Kroah-Hartman
2022-04-26  2:27           ` Peter Hutterer
2022-04-26  7:14             ` Oliver Neukum
2022-04-26  7:21               ` Greg Kroah-Hartman
2022-04-26  8:46                 ` Oliver Neukum
2022-04-26 10:07                   ` Bastien Nocera
2022-04-26 10:30                     ` Greg Kroah-Hartman
2022-04-26 10:37                       ` Bastien Nocera
2022-04-26 11:10                         ` Greg Kroah-Hartman
2022-04-28 10:28                         ` Oliver Neukum
2022-04-28 11:21                           ` Bastien Nocera [this message]
2022-04-26 10:07             ` Bastien Nocera
2022-04-26 10:07           ` Bastien Nocera
2022-04-25 16:14         ` Alan Stern
2022-04-25 17:09           ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4c72d3d8d25f25bd12cdfbf3e7efe3ea1c3f0a7.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=peter.hutterer@who-t.net \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox