From: Jie Deng <dengjie03@kylinos.cn>
To: Michal Pecio <michal.pecio@gmail.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
mathias.nyman@intel.com, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: Restore MSI/MSI-X reinitialization on resume for RESET_ON_RESUME hosts
Date: Fri, 31 Jul 2026 15:38:22 +0800 [thread overview]
Message-ID: <d71b1b08-eae8-4e0a-a58f-bbd6b131d5cd@kylinos.cn> (raw)
In-Reply-To: <20260730064817.79e3d1af.michal.pecio@gmail.com>
Thank you for your reply.
在 2026/7/30 12:48, Michal Pecio 写道:
> To avoid putting PCI-specific code in xhci.c, I wonder if it would
> still work if the disable/enable cycle is done by xhci_pci_resume()
> before calling xhci_resume()?
The architecture is indeed cleaner. I will reply to you after conducting
the test.
> I wonder if it's an issue with those chips or a general PCIe or IRQ
> resume bug in some particular host system? It looks like nobody else
> complained about this old patch for three years.
>
> I don't have ASM3042, but I do have ASM1042, ASM1142, ASM3142 and
> also uPD720200, uPD720201 (rarely available for testing), uPD720202.
> To be honest, I have never seen lost IRQs after resume here.
I was testing the S3 reproducibility issue on the ARM64 platform
(uPD720201 requires manually adding the XHCI_RESET_ON_RESUME quirk).
Next, I will conduct a comparison verification on the x86 platform,
which will take some time.
> How often is this supposed to happen, how exactly is it reproduced?
Approximately 200 iterations of S3 were needed to consistently reproduce
the issue.
The S3 test script is as follows:
#! /bin/bash
#
for i in $(seq 1 $1); do
echo "the $i th s3" > /dev/ttyAMA0
echo "the $i th s3"
rtcwake -m mem -s 20
sleep 15
done
next prev parent reply other threads:[~2026-07-31 7:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 9:02 [PATCH] usb: xhci: Restore MSI/MSI-X reinitialization on resume for RESET_ON_RESUME hosts Jie Deng
2026-07-27 14:19 ` Mathias Nyman
2026-07-30 2:24 ` Jie Deng
2026-07-30 4:48 ` Michal Pecio
2026-07-31 7:38 ` Jie Deng [this message]
2026-07-31 10:57 ` Michal Pecio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d71b1b08-eae8-4e0a-a58f-bbd6b131d5cd@kylinos.cn \
--to=dengjie03@kylinos.cn \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=michal.pecio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).