Re: [PATCH v2] usbip: tools: Add usbip host driver availability check

Greg KH
2026-03-26T08:43:33Z

On Thu, Mar 26, 2026 at 11:10:02AM +0800, Zongmin Zhou wrote:
>
> On 2026/3/25 16:58, Greg KH wrote:
> > On Wed, Mar 25, 2026 at 10:26:34AM +0800, Zongmin Zhou wrote:
> > > From: Zongmin Zhou <zhouzongmin@kylinos.cn>
> > >
> > > Currently, usbip_generic_driver_open() doesn't verify that the required
> > > kernel module (usbip-host or usbip-vudc) is actually loaded.
> > > The function returns success even when no driver is present,
> > > leading to usbipd daemon run success without driver loaded.
> > >
> > > So add a check function to ensure usbip host driver has been loaded.
> > >
> > > Suggested-by: Shuah Khan <skhan@linuxfoundation.org>
> > > Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn>
> > > ---
> > > Changes in v2:
> > > - Use system calls directly instead of checking sysfs dir.
> > >
> > > tools/usb/usbip/libsrc/usbip_device_driver.c | 7 +++++--
> > > tools/usb/usbip/libsrc/usbip_host_driver.c | 8 ++++++--
> > > 2 files changed, 11 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/tools/usb/usbip/libsrc/usbip_device_driver.c b/tools/usb/usbip/libsrc/usbip_device_driver.c
> > > index 927a151fa9aa..45ab647ef241 100644
> > > --- a/tools/usb/usbip/libsrc/usbip_device_driver.c
> > > +++ b/tools/usb/usbip/libsrc/usbip_device_driver.c
> > > @@ -136,10 +136,13 @@ static int usbip_device_driver_open(struct usbip_host_driver *hdriver)
> > > hdriver->ndevs = 0;
> > > INIT_LIST_HEAD(&hdriver->edev_list);
> > > - ret = usbip_generic_driver_open(hdriver);
> > > - if (ret)
> > > + if (system("/sbin/lsmod | grep -q usbip_vudc")){
> > What happens if the module is built into the kernel?
> >
> > > err("please load " USBIP_CORE_MOD_NAME ".ko and "
> > > USBIP_DEVICE_DRV_NAME ".ko!");
> > > + return -1;
> > > + }
> > > +
> > > + ret = usbip_generic_driver_open(hdriver);
> > > return ret;
> > > }
> > > diff --git a/tools/usb/usbip/libsrc/usbip_host_driver.c b/tools/usb/usbip/libsrc/usbip_host_driver.c
> > > index 573e73ec36bd..f0ac941d4f6e 100644
> > > --- a/tools/usb/usbip/libsrc/usbip_host_driver.c
> > > +++ b/tools/usb/usbip/libsrc/usbip_host_driver.c
> > > @@ -31,10 +31,14 @@ static int usbip_host_driver_open(struct usbip_host_driver *hdriver)
> > > hdriver->ndevs = 0;
> > > INIT_LIST_HEAD(&hdriver->edev_list);
> > > - ret = usbip_generic_driver_open(hdriver);
> > > - if (ret)
> > > + if (system("/sbin/lsmod | grep -q usbip_host")){
> > Same here, what happens if it is built in?
> Thank you for pointing this out.
> I apologize for not considering the built-in module case.
>
> You are right that using lsmod | grep would incorrectly fail when usbip_host
> is built into the kernel (CONFIG_USBIP_HOST=y).
> Usbip has always been built as a loadable module (.ko) by default, which led
> to this oversight.
>
> To address this issue, would the following approach be acceptable?

Wait, what "issue" are you trying to fix here? Why can't you just check
for opening the correct device node when the host opens the file and if
that fails, report an error? Doesn't that happen today already?

> 1. Uses /sys/module/usbip_host to check wehther had been loaded, which
> exists for both loadable modules and built-in drivers.
> 2. Attempts to load the module via modprobe if it is not already loaded.

Don't do module autoloading, that might surprise users that previously
were not expecting it.

thanks,

greg k-h