linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ajay Gupta <ajayg@nvidia.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Peter Rosin <peda@axentia.se>
Cc: "wsa@the-dreams.de" <wsa@the-dreams.de>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: [v12,1/2] i2c: buses: add i2c bus driver for NVIDIA GPU
Date: Thu, 13 Sep 2018 23:32:30 +0000	[thread overview]
Message-ID: <d8eea6966f5248dd8880e23930217f4e@bgmail101.nvidia.com> (raw)

Hi Heikki and Peter,

> > > Can we get the working set in while the issues is being debugged?
> >
> > I'm not the one making the decision, and I don't even know if this is
> > going through the i2c or the usb tree? If it's going through the i2c
> > tree you need a tag from the usb people (Greg?) on patch 2/2, and if
> > it's going through the usb tree, you need a tag from Wolfram on patch
> > 1/2. As I said, I'm not involved with that part, I'm just reviewing
> > these patches because I felt like it.
> >
> > The remaining issue that bothers me is the looping reads, and your
> > email address reveals that you should be in a very good position to
> > work out why they do not work, and fix it or let us know why they
> > don't.
I am working with different teams to debug this and I think it may take
some time to know the root cause.

>> However, your responses indicate that you have given up. That
> > coupled with the fact that the datasheet is not publicly available
> > (but why, seems a little over-protective to think the interface to an
> > i2c controller is worth all that much) makes me think that perhaps
> > this little detail might never be fixed if it's not fixed now. Once
> > merged, there is no pressure on you to actually do anything about it,
> > and others are stuck in darkness without a spec.
> 
> I got similar impression. Ajay, you have really made it look like you just want
> to dump the code even though it still has problems, then lift your arms and
> never look back. I'm sure that is not the case, but the fact that you are
> continuously making pleas, asking us to just accept the code even though it is
> not ready, does give that impression.
> I can appreciate that you are in a hurry, and I know you have a lot of other
> tasks that also need your attention, just like everybody, but I'm asking you to
> take a deep breath, and take one more look at these two drivers. Go over the
> code as a whole instead of trying to fix the problems as fast as possible
> (you've sent a new version almost daily).
> I'm certain you can figure out how to fix that last issue. You are almost there.
> 
> And when you are ready, please include a cover letter in your next version and
> provide some background for these patches if you can.
Ok.

Thanks
Ajay

--nvpublic
> Ideally you could tell something about the platform that has that the PD
> controller and the I2C host. There you can also mention which tree you think
> these patches should go through, usb or i2c. I'm guessing usb based on the
> fact that the I2C host controller driver seems to be there just for the USB PD
> controller, at least for now.
> 
> 
> Thanks,
> 
> --
> heikki

             reply	other threads:[~2018-09-13 23:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13 23:32 Ajay Gupta [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-24 19:44 [v12,1/2] i2c: buses: add i2c bus driver for NVIDIA GPU Greg Kroah-Hartman
2018-10-24 17:46 Ajay Gupta
2018-10-16 23:21 Wolfram Sang
2018-10-16 17:46 Peter Rosin
2018-10-02 16:34 Ajay Gupta
2018-10-02  7:27 Wolfram Sang
2018-10-01 22:04 Ajay Gupta
2018-10-01 21:16 Ajay Gupta
2018-10-01 19:51 Peter Rosin
2018-10-01 19:37 Wolfram Sang
2018-10-01 19:33 Ajay Gupta
2018-09-13 11:11 Heikki Krogerus
2018-09-13  7:36 Peter Rosin
2018-09-12 22:22 Ajay Gupta
2018-09-12 21:57 Peter Rosin
2018-09-12 18:02 Ajay Gupta
2018-09-12 11:02 Peter Rosin
2018-09-12 10:25 Peter Rosin
2018-09-11 22:48 Ajay Gupta
2018-09-11 20:57 Peter Rosin
2018-09-11 17:45 Ajay Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8eea6966f5248dd8880e23930217f4e@bgmail101.nvidia.com \
    --to=ajayg@nvidia.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).