From: Dmitry Osipenko <digetx@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Matt Merhar <mattmerhar@protonmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Peter Geis <pgwipeout@gmail.com>, Ion Agorria <ion@agorria.com>,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/8] usb: host: ehci-tegra: Remove the driver
Date: Thu, 17 Dec 2020 22:43:33 +0300 [thread overview]
Message-ID: <dae2cf1c-68ae-19e7-d5aa-74266aa5239f@gmail.com> (raw)
In-Reply-To: <20201217155003.GA280158@rowland.harvard.edu>
17.12.2020 18:50, Alan Stern пишет:
> On Thu, Dec 17, 2020 at 12:40:06PM +0300, Dmitry Osipenko wrote:
>> The ChipIdea driver now provides USB2 host mode support for NVIDIA Tegra
>> SoCs. The ehci-tegra driver is obsolete now, remove it and redirect the
>> older Kconfig entry to the CI driver.
>>
>> Tested-by: Matt Merhar <mattmerhar@protonmail.com>
>> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
>> Tested-by: Peter Geis <pgwipeout@gmail.com>
>> Tested-by: Ion Agorria <ion@agorria.com>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>> drivers/usb/host/Kconfig | 8 +-
>> drivers/usb/host/Makefile | 1 -
>> drivers/usb/host/ehci-tegra.c | 604 ----------------------------------
>> 3 files changed, 6 insertions(+), 607 deletions(-)
>> delete mode 100644 drivers/usb/host/ehci-tegra.c
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index 31e59309da1f..318315602337 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -269,9 +269,13 @@ config USB_EHCI_HCD_AT91
>> config USB_EHCI_TEGRA
>> tristate "NVIDIA Tegra HCD support"
>> depends on ARCH_TEGRA
>> - select USB_EHCI_ROOT_HUB_TT
>> - select USB_TEGRA_PHY
>> + select USB_CHIPIDEA
>> + select USB_CHIPIDEA_HOST
>> + select USB_CHIPIDEA_TEGRA
>> help
>> + This option is deprecated now and the driver was removed, use
>> + USB_CHIPIDEA_TEGRA instead.
>> +
>> This driver enables support for the internal USB Host Controllers
>> found in NVIDIA Tegra SoCs. The controllers are EHCI compliant.
>
> It doesn't really make sense to say "... the driver was removed..."
> and then in the next paragraph say "This driver enables...". You
> should change the second paragraph to begin: "Enable support for...".
>
> That's a minor matter, though, and you can easily fix it in the next
> patch version. Everything else is okay.
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
Okay, thanks.
next prev parent reply other threads:[~2020-12-17 19:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 9:39 [PATCH v2 0/8] Support Runtime PM and host mode by Tegra ChipIdea USB driver Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 1/8] usb: phy: tegra: Add delay after power up Dmitry Osipenko
2020-12-17 13:25 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 2/8] usb: phy: tegra: Support waking up from a low power mode Dmitry Osipenko
2020-12-17 13:33 ` Thierry Reding
2020-12-17 13:47 ` Dmitry Osipenko
2020-12-17 15:04 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 3/8] usb: chipidea: tegra: Remove MODULE_ALIAS Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 4/8] usb: chipidea: tegra: Rename UDC to USB Dmitry Osipenko
2020-12-17 13:36 ` Thierry Reding
2020-12-17 14:00 ` Dmitry Osipenko
2020-12-17 9:40 ` [PATCH v2 5/8] usb: chipidea: tegra: Support host mode Dmitry Osipenko
2020-12-17 13:40 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 6/8] usb: chipidea: tegra: Support runtime PM Dmitry Osipenko
2020-12-17 13:41 ` Thierry Reding
2020-12-17 13:45 ` Dmitry Osipenko
2020-12-17 15:02 ` Thierry Reding
2020-12-17 19:51 ` Dmitry Osipenko
2020-12-17 15:02 ` Thierry Reding
2020-12-17 9:40 ` [PATCH v2 7/8] usb: host: ehci-tegra: Remove the driver Dmitry Osipenko
2020-12-17 13:42 ` Thierry Reding
2020-12-17 15:50 ` Alan Stern
2020-12-17 19:43 ` Dmitry Osipenko [this message]
2020-12-17 9:40 ` [PATCH v2 8/8] ARM: tegra_defconfig: Enable USB_CHIPIDEA and remove USB_EHCI_TEGRA Dmitry Osipenko
2020-12-17 13:45 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dae2cf1c-68ae-19e7-d5aa-74266aa5239f@gmail.com \
--to=digetx@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ion@agorria.com \
--cc=jonathanh@nvidia.com \
--cc=kwizart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mattmerhar@protonmail.com \
--cc=pgwipeout@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).