From: Randy Dunlap <rdunlap@infradead.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Felipe Balbi <balbi@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency
Date: Thu, 14 Jun 2018 13:20:04 -0700 [thread overview]
Message-ID: <db22cad5-c25f-1b34-1784-5df5ed1ac0b2@infradead.org> (raw)
On 06/11/2018 09:29 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2018-05-30 at 15:29 +0300, Felipe Balbi wrote:
>> Hi,
>>
>> Arnd Bergmann <arnd@arndb.de> writes:
>>> Without that option, we run into a link failure:
>>>
>>> drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request':
>>> hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string'
>>>
>>> Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
>
> Greg, can you send this to Linus asap ? Some people are hitting build
> breakages upstream because of this.
Agreed.
> Thanks !
ditto.
next reply other threads:[~2018-06-14 20:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 20:20 Randy Dunlap [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-06-12 4:29 usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency Benjamin Herrenschmidt
2018-05-30 12:29 Felipe Balbi
2018-05-28 23:49 Benjamin Herrenschmidt
2018-05-25 16:07 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db22cad5-c25f-1b34-1784-5df5ed1ac0b2@infradead.org \
--to=rdunlap@infradead.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).