From: Sanjay R Mehta <sanmehta@amd.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Sanjay R Mehta <Sanju.Mehta@amd.com>,
andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, Basavaraj.Natikar@amd.com,
jagadish.hadimani@amd.com, sachinkumar.butte@amd.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Retain host router DP IN resources during suspend
Date: Sun, 20 Feb 2022 17:27:46 +0530 [thread overview]
Message-ID: <db25ec12-33db-224d-b575-44a9a3b332c9@amd.com> (raw)
In-Reply-To: <Yg+sXedW1RFa65SE@lahna>
On 2/18/2022 7:55 PM, Mika Westerberg wrote:
> On Fri, Feb 18, 2022 at 07:38:23PM +0530, Sanjay R Mehta wrote:
>>
>>
>> On 2/18/2022 4:43 PM, Mika Westerberg wrote:
>>> Hi Sanjay,
>>>
>>> On Fri, Feb 18, 2022 at 01:11:25AM -0600, Sanjay R Mehta wrote:
>>>> From: Sanjay R Mehta <sanju.mehta@amd.com>
>>>>
>>>> All DP resources are released during suspend and while
>>>> resuming back DP IN resource is not available, therefore
>>>> unable to find DP pair to re-establish the DP tunnel.
>>>
>>> It should get plug event for the DP IN adapters once the router comes
>>> back from sleep. Is that not happening here?
>>
>> Yes, plug event is not happening for the DP IN adapter after resume.
>>
>> The DP In resources are put into tcm->dp_resources list as part of host
>> router enumeration. But when it resumes from sleep, there is no plug
>> event happening for DP IN, hence DP IN resource will not be in
>> tcm->dp_resources list.
>
> Right but if I understand the spec correctly you should get a new
> hotplug event for the DP IN adapters once the host router is moved back
> to "enumerated" state. This is how Intel hardware works at least (and
> this is the understanding I have from the USB4 spec too). Do you see
> anything in the log wrt. this when you resume the domain?
Thanks Mika. I'll re-look at this scenario on our system and will check
if anything needs to be taken care of.
Thank you for the valuable input :).
>
prev parent reply other threads:[~2022-02-20 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 7:11 [PATCH] thunderbolt: Retain host router DP IN resources during suspend Sanjay R Mehta
2022-02-18 11:13 ` Mika Westerberg
2022-02-18 14:08 ` Sanjay R Mehta
2022-02-18 14:25 ` Mika Westerberg
2022-02-20 11:57 ` Sanjay R Mehta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db25ec12-33db-224d-b575-44a9a3b332c9@amd.com \
--to=sanmehta@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=jagadish.hadimani@amd.com \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=sachinkumar.butte@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox