Re: [PATCH v2 2/6] serial: core: add sysfs attribute to suppress ready signalling on open

Jiri Slaby
2022-06-02T08:50:23Z

On 02. 06. 22, 10:35, Mychaela Falconia wrote:
> Jiri Slaby wrote:
>
>> s@ttyS0@ttyS<x>@
>> [...]
>> sysfs_emit()? (Even if I know %d won't overflow PAGE_SIZE :P.)
>
> Thanks for the feedback - saving it for v3 of my patch series.
>
> Any comments, positive or negative, on the principal/philosophical
> idea behind this proposed patch series?

Neutral. As long as you break no currently supported devices.

I've just noticed the double negative "!tty_port_nordy()" on both calls
of that function. I guess there was already a discussion about the
naming, but wouldn't it make more sense to dub it like tty_port_do_rtscts()?

thanks,
--
js
suse labs