From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Fan Wu <fanwu01@zju.edu.cn>, linux-usb@vger.kernel.org
Cc: bryan.odonoghue@linaro.org, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] usb: typec: qcom-pmic-typec: disable cc_debounce_dwork on stop
Date: Thu, 20 Aug 2026 10:13:33 +0200 [thread overview]
Message-ID: <e06004a4-4ed8-46f4-a949-8cece1348ddb@oss.qualcomm.com> (raw)
In-Reply-To: <20260819161950.77858-1-fanwu01@zju.edu.cn>
On 8/19/26 6:19 PM, Fan Wu wrote:
> cc_debounce_dwork lives on the system workqueue but is armed from
> tcpm callbacks (set_cc/start_toggling). Those callbacks run on tcpm's
> kthread worker which is only destroyed by tcpm_unregister_port(), after
> port_stop() has already returned, opening a potential race window where
> tcpm's worker flush re-arms the work.
[...]
> --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_port.c
> @@ -694,6 +694,8 @@ static void qcom_pmic_typec_port_stop(struct pmic_typec *tcpm)
>
> for (i = 0; i < pmic_typec_port->nr_irqs; i++)
> disable_irq(pmic_typec_port->irq_data[i].irq);
> +
> + disable_delayed_work_sync(&pmic_typec_port->cc_debounce_dwork);
Doesn't this make disable_irq() get called undesirably?
Konrad
next prev parent reply other threads:[~2026-08-20 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 16:19 [PATCH] usb: typec: qcom-pmic-typec: disable cc_debounce_dwork on stop Fan Wu
2026-08-20 8:13 ` Konrad Dybcio [this message]
2026-08-20 8:52 ` Fan Wu
2026-08-20 10:18 ` Bryan O'Donoghue
2026-08-20 13:53 ` [PATCH v2 0/2] usb: typec: qcom-pmic-typec: cc_debounce_dwork lifetime fixes Fan Wu
2026-08-20 13:53 ` [PATCH v2 1/2] usb: typec: qcom-pmic-typec: disable cc_debounce_dwork on stop Fan Wu
2026-08-31 9:56 ` Heikki Krogerus
2026-08-20 13:53 ` [PATCH v2 2/2] usb: typec: qcom-pmic-typec: drain cc_debounce_dwork if port_start() fails Fan Wu
2026-08-31 9:57 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e06004a4-4ed8-46f4-a949-8cece1348ddb@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=fanwu01@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox