From: "Herrenschmidt, Benjamin" <benh@amazon.com>
To: "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"neal_liu@aspeedtech.com" <neal_liu@aspeedtech.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"balbi@kernel.org" <balbi@kernel.org>
Subject: Re: [PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0
Date: Fri, 24 Jun 2022 06:17:31 +0000 [thread overview]
Message-ID: <e0b1c201bec2ccb68d1779ea8e9cfdf27563dd73.camel@amazon.com> (raw)
In-Reply-To: <20220623064320.GN16517@kadam>
On Thu, 2022-06-23 at 09:43 +0300, Dan Carpenter wrote:
> On Thu, Jun 23, 2022 at 01:41:49AM +0000, Neal Liu wrote:
> > > The bug is that we should still enter this loop if "tx_len" is
> > > zero.
> > >
> > > After adding the "last" variable, then the "chunk >= 0" condition
> > > is no longer
> > > required but I left it for readability.
> > >
> >
> > Use either "chunk >=0" or "last".
> > I think the former is more simpler.
>
> chunk >= 0 doesn't work. last works but I think this way is more
> readable.
Hrm... what is that driver ? I've missed it ... is the code lifted from
aspeed-vhub ? If yes, should we instead make it a common code base ?
And if there are bug fixes on one they might apply to the other as
well...
Neal, is that "UDC" IP block the same that resides under the vhub ? If
yes then this really needs to be a common driver instead, using the
code existing in aspeed-vhub, simply making it able to work without a
parent vhub pointer.
Cheers,
Ben.
next prev parent reply other threads:[~2022-06-24 6:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 14:50 [PATCH] usb: gadget: aspeed_udc: fix handling of tx_len == 0 Dan Carpenter
2022-06-23 1:41 ` Neal Liu
2022-06-23 6:43 ` Dan Carpenter
2022-06-23 7:22 ` Dan Carpenter
2022-06-23 7:52 ` Neal Liu
2022-06-23 7:55 ` Dan Carpenter
2022-06-23 8:37 ` Neal Liu
2022-06-24 6:17 ` Herrenschmidt, Benjamin [this message]
2022-06-24 6:34 ` Dan Carpenter
2022-06-24 6:39 ` Benjamin Herrenschmidt
2022-06-24 7:46 ` Neal Liu
2022-06-27 1:30 ` Benjamin Herrenschmidt
2022-06-28 7:17 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0b1c201bec2ccb68d1779ea8e9cfdf27563dd73.camel@amazon.com \
--to=benh@amazon.com \
--cc=balbi@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox