From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36045C001DE for ; Tue, 25 Jul 2023 14:36:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232714AbjGYOgN (ORCPT ); Tue, 25 Jul 2023 10:36:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231213AbjGYOgL (ORCPT ); Tue, 25 Jul 2023 10:36:11 -0400 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEB7E102 for ; Tue, 25 Jul 2023 07:36:10 -0700 (PDT) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-31751d7d96eso2298133f8f.1 for ; Tue, 25 Jul 2023 07:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690295709; x=1690900509; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xfNNK+Jw74jqrCAqxAeojiuG95OBtByVK1mJKH9RnMw=; b=T5/5jtv9F/jWpWOT82LpZO4nTcLi+t+ir+tG32DTdSqXgkhfQuP28GdKPI16whdPPJ IC81DAp8VwqRqXJex6Swdwjn2z19Abfpw+R5ZHVoasb2HmgCxUgloPdQywMhJoB3RWYL Mg+QFkw2H/qC8F9BjVLqOz44thN6Cc/iP09xxWyE6uYqbybGslxojDgp9NSic5O7srys LPfc449MuH6D5leaBxwZsV/jaEPDxSrIGTXpKF//HneoCWl++HRl85i615gGD2A1BjVw KoFiOtq1bTq75L3/qCCGfaP0ZJ7gIuc85u3ki/MW380x+S6h+SStPT4+i5f3I8B73vuW 11XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690295709; x=1690900509; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xfNNK+Jw74jqrCAqxAeojiuG95OBtByVK1mJKH9RnMw=; b=acr/KNi1PWqzW9EpBF2DmM0eNCT3L5JADtvvhzjt3jg7b0ApxP+hS864yaDHZMS/2u Tcme/CzIF6n9z70wxzZk7q8H4UHg3wZI+HWxultKk61sbJMk+tj2kplMHnn3bgIXbmBb q/Mju5k2d7AzGo8NisaB422POrFOke/+kpQ+fuZALejeaQ30kOgsmUmX1nyr12XQGboE HvznxhUeY7CReuQSFAaTZhQ5lxovkCZZsWJWm+zCB9mQoxd0j1YhxmExPqoNLOv0YHzn V5fnLjtMLOdy7hLDERE8U7hOssUnKBupnRAKr3rBkEUKSfiEx9DkghCCBFRaQa8bkWb/ 85qg== X-Gm-Message-State: ABy/qLYMEsTnp4nmmlRsUfuRK3PpFM3B3jDaJ9fZKyS/9vj/oCAQpNZ7 v8Xrz2ud9eAuWIQVO6hqbB+42iDqJIRM+2Eb7fw= X-Google-Smtp-Source: APBJJlFiVPhfb1GfgNtwVodItt0v4QcSUUEBiKLz58kaCDmEyFPmbNi36CHoHy1qhesBw6bJU2XfDw== X-Received: by 2002:a5d:50c6:0:b0:317:5b5f:3348 with SMTP id f6-20020a5d50c6000000b003175b5f3348mr5461667wrt.71.1690295709150; Tue, 25 Jul 2023 07:35:09 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id j9-20020a5d4529000000b0030fd03e3d25sm16550394wra.75.2023.07.25.07.35.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 07:35:08 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 15:35:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] usb: typec: qcom: fix return value check in qcom_pmic_typec_probe() Content-Language: en-US To: Yang Yingliang , linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, gregkh@linuxfoundation.org, caleb.connolly@linaro.org References: <20230725125319.565733-1-yangyingliang@huawei.com> From: Bryan O'Donoghue In-Reply-To: <20230725125319.565733-1-yangyingliang@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 25/07/2023 13:53, Yang Yingliang wrote: > device_get_named_child_node() returns NULL, if it fails, replace > IS_ERR() with NULL pointer check. > > Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") > Signed-off-by: Yang Yingliang > --- > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > index a905160dd860..9b467a346114 100644 > --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c > @@ -209,8 +209,8 @@ static int qcom_pmic_typec_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, tcpm); > > tcpm->tcpc.fwnode = device_get_named_child_node(tcpm->dev, "connector"); > - if (IS_ERR(tcpm->tcpc.fwnode)) > - return PTR_ERR(tcpm->tcpc.fwnode); > + if (!tcpm->tcpc.fwnode) > + return -EINVAL; > > tcpm->tcpm_port = tcpm_register_port(tcpm->dev, &tcpm->tcpc); > if (IS_ERR(tcpm->tcpm_port)) { Acked-by: Bryan O'Donoghue