From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F4201B4F1F for ; Mon, 30 Mar 2026 13:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774877433; cv=none; b=Gg6sUqaS9+alrTiqQoFbeZ5C3RQ8R+3fzRw+OogSJ/tMBxXQtwiyUav35Bm9AAUwA0SKAtPtgih1sOeiq5B4oG9tksIRRQwLu3CTcUWW9Tw2hRupwnSjZlPmz7gg0ZvGYITQrnRg+Ue+Yi1E2ZaIw504FElcS0Q25NHM06T7kug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774877433; c=relaxed/simple; bh=PWI9pxJMUliAWSxOIp1fSPLGEwUcRFIYY006I5gutzY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FZFVMDBwGaNzHngALzjSS7Wf9eOm5STknsg19Jx/onPXx2Nd06X/m6SHaFnKmR8WfBjIO8ObwvELJRMNAbCrIIorIB6GE4vjTy6gw/Do0K8HqjyEyU/gCDqx4j30vHwX2dvfoWwRoOw6KRtw11vZdsDK/nY2HAw7+wSvgytS0cs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jmQoRjvV; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jmQoRjvV" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a13a06fc85so5579168e87.1 for ; Mon, 30 Mar 2026 06:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774877429; x=1775482229; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=77WeHT8C34JNWFQ0DtWQQvXMSZXQxoGR8B6oehAckGQ=; b=jmQoRjvVwOVvx6r72QPQI64ow/RiqnyE+p5PAwu+jdfvFRleymitXjvksg+5siCqJH po8FCgj25Yf1EZYgLbW8KaFPpDgrziD/IWpi5OoxsnbtB/hKoOfHvtxMUgCPtqZzSfe+ T+h3DamHNJeRsMyZUaZAExSx8PZh5UuKWacCRTuftDMDxLxBtGiluNAHIku5TE7a4CKv /sYauYVYYqgiGfnmCsdnq7dm4f7awud3DmqHAyfKVwxekQRTG4JE53vFA9Owllt33DcZ wAM9dJRB5D1l1HZ2Ht7sZaBp/LLjeElXSWkV3kMbiqj9Ipk+rzHpFUqhng8UKLmUVDU9 D8Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774877429; x=1775482229; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=77WeHT8C34JNWFQ0DtWQQvXMSZXQxoGR8B6oehAckGQ=; b=XExxbGiO8xQOhLCwfNCgY6kIu2h23MFZNU3WTRiHcY/tB3ebtFk7L7UpOBvIs0txiK mJuGWXMpAFJM50snA4kMIbXh8kmxXkLjWvSRMtljZJjpTIFAa6mIoVV9/TvyA3Xh5aPl NkrWVdEUpocL3TiVVpbltd51glMUCfc11C3GdLbkTRtzgQC0btFor2Rt8zwjzn3k+xBo RKSYnne9TPp6YeS/1MZP7aKbo31t/kkg9HYpIh/GYYuxJ4jDx9PRlDv6Gq4mg2LHfjDd Omdz2JQmw3JolYSg/NqRM1y5o2QvUwqXi0zDS5slNfYAuhjKgc4mL5gdBti1MK4S16fv wt9g== X-Forwarded-Encrypted: i=1; AJvYcCUdVvkog6RiyN3pr+yMPxRFll2wVycisThK3ejsumGPZLsgGCuRpf43erblRWahhTdhlJyJTlbxRhY=@vger.kernel.org X-Gm-Message-State: AOJu0YwvZd2+x66jjVDEjGsG24FWJwMHj9DGG3BnSPiWbmYXhE7296NK OFnxXKrAHP/E3gY04pqQwdioyE/SMQQ+DDVcx8DDHm0tXwBtEqMOw3SW X-Gm-Gg: ATEYQzzeQTu3xJBIwMn2goxP+eBOK4/ZVSSYn+htumD6/3xWjk/FXnIKveCQ+KiXrWz DNFSFh2sqRvUbhKP4yb1Rn1+++R/0tLmGuo6Abdiko0lp8kt7d5C17bYm0uJx7pBQCtbZOxZNYm wZAvp03YiySyub0tGsYEm0Ah/OsVei8Wol0dC2/aGtRJbZY9kiPlG+VsZKFLsyCyjvyVcapwHWY ZQpbmqDn96o4n+VmWEG4A6OtA9HWhJYeEm8alf+cWKFxfL1cwgeG+53PqeHs784QZpp5aOB1Ymu uKqgvGR+xcbg1KINpHP946tKnVNLJ6iVS2aHZigUo3EJ/EFhYVU+epBj7YRKnI98xNiLBiwlmd5 3tXOsN/vbYCb2DkOIr2mGSnA5bs6JdGxcsf4GfhOoAwERKqGW2Fpr6V4RJ/8GobFyzPQWTCmnsH UOGFl2TC3eVHhc39it7gvxlXYUr9xLgVYyztz8gBRe1fVWFAtU5lGh3T/eE81ZTnQ+ExQTXv17s 18kxSSo1ZGmHNHqaQ== X-Received: by 2002:a05:6512:3b8f:b0:5a2:a355:aa4e with SMTP id 2adb3069b0e04-5a2ab927773mr5628324e87.31.1774877429070; Mon, 30 Mar 2026 06:30:29 -0700 (PDT) Received: from ?IPV6:2a00:1fa0:2c2:728e:63f1:6154:c8be:fcb7? ([2a00:1fa0:2c2:728e:63f1:6154:c8be:fcb7]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2b13f549dsm1643949e87.14.2026.03.30.06.30.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Mar 2026 06:30:26 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 16:30:25 +0300 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: cdns3: gadget: fix NULL pointer dereference in ep_queue To: "Peter Chen (CIX)" , Yongchao Wu Cc: Pawel Laszczak , Roger Quadros , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260328143842.57315-1-yongchao.wu@autochips.com> <20260329013404.116481-1-yongchao.wu@autochips.com> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/30/26 12:21 PM, Peter Chen (CIX) wrote: [...] >> When the gadget endpoint is disabled or not yet configured, the ep->desc >> pointer can be NULL. This leads to a NULL pointer dereference when >> __cdns3_gadget_ep_queue() is called, causing a kernel crash. >> >> Add a check to return -ESHUTDOWN if ep->desc is NULL, which is the >> standard return code for unconfigured endpoints. >> >> This prevents potential crashes when ep_queue is called on endpoints >> that are not ready. >> >> Signed-off-by: Yongchao Wu > > Add Fixed-by tag and Cc to stable tree please, others: I think you meant the Fixes tag. :-) [...] MBR, Sergey