From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973175.qiye.163.com (mail-m1973175.qiye.163.com [220.197.31.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C73035CB7F; Wed, 2 Sep 2026 01:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.75 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788314133; cv=none; b=VID3W8Pq2ylNpVmTRsDqKMPXFZcbGVe0DKCEDcQgzxt+X8P5CB9bbzw+8O+NIa1lguv4d4WpDJ0DkOtyBdZjXaYG+ohmTInddn03f6bqi0C2UfCS+Jzo//g/Jcwz6ybaQsAkRAvdefoUm5iARcE6a3+o3o/4UkSj0AVRREO6q78= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788314133; c=relaxed/simple; bh=2w3Kv0IkBiFoQ0r/sF0oZdyEMhJ/GKDTKyP9z4kDN+4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tw9Dy0gEHNYo4C4571JyKGr0jidOFuzxVG1s/c0uncg5OwmpsDESvepWHfMDuqV0HbGZK4/XQ47kN1JaX7nC9yJDN0BFZ7CaKwaMwZToqFzDoXrahjvmYXBaHFbhg2hL5vW4opvypyuDcCudzFBJ+nTWR/GX8vroEUj1y/GYYUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=LYgXzsjW; arc=none smtp.client-ip=220.197.31.75 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="LYgXzsjW" Received: from [172.16.12.90] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 4c2d816b7; Wed, 2 Sep 2026 09:39:53 +0800 (GMT+08:00) Message-ID: Date: Wed, 2 Sep 2026 09:39:03 +0800 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] usb: onboard_dev: add the Rockchip rk1808 To: Rudi Heitbaum , =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: Matthias Kaehlcke , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <5096877.GXAFRqVoOG@phil> <4512468.iIbC2pHGDl@diego> <84A6832DFD4B9FF2+64806113-d65e-448a-b2c4-ee83e125a665@airkyi.com> Content-Language: en-US From: Chaoyi Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-HM-Tid: 0aa05fc5cbe003a7kunm6f9d1f9f758db1 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZGBkYVhpLHk8fSU9NH08ZSlYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=LYgXzsjWBJSLWVrpHcoTEHvfZCqyfTpvw27cThFxaxfv+/JZTueYpbZ7RtZAe0igqtVGLYWwIfdFHuCP0pH+z174t6s/zFGIrI7SJ1nndbktJh45Uqe6I+fj5+rnAwMT1JHHn1sSvG04MNdmdzgpize/KSAEq/KwAM/rTahZuqQ=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=ep+oq+yHnM/WBMJtlCFUdAjPKEh0uJ3B/SDc5WqQzHc=; h=date:mime-version:subject:message-id:from; Hello Rudi, On 9/1/2026 7:42 PM, Rudi Heitbaum wrote: > On Mon, Aug 31, 2026 at 09:41:08AM +0800, Chaoyi Chen wrote: >> Hello Rudi, >> >> On 8/28/2026 9:24 PM, Rudi Heitbaum wrote: >>> Hi Heiko, >>> >>> I hadn't looked in to these from the mainline viewpoint. I had been >>> using an adapted vendor script based on the radxa npu_powerctl binary >>> which reimplements the npu_reset sequence over GPIO. > ... >>> I have the schematics and the working N10 here, so let me look into >>> describing these in the .dts and update the onboard_usb_dev.h. >>> >> >> Perhaps we should first check whether the power-on sequence in >> onboard_usb_dev.c meets the requirements, as it enables all >> regulator supplies at the same time. > > Hi Chaoyi and Heiko, > > I have done some work on the bringup of the rk1808, and can confirm that > it needs six rails up and its reset released before it appears on the > bus. There are no ordering requirements, issuing the reset 25 ms later > is reliably working. The supply names being "vdd", "vddlog", "vddcpu", > "vdd0v8", "vcc1v8", "vccio". This moves the power-on into the kernel > and not the userland script. > > The MAX_SUPPLIES fixed size array needs to be expanded from 2 to 6 to > accommodate the rails. > > The rock-pi-n10 and the on-die rk1808 (including the onboard VIP8000Nano-Q > NPU) are now both running on the 7.2 mainline kernel. The > rock-pi-n10/rk3399pro-vmarc-som is booting with the mainline .dts and > the rk1808 is booting with an adapted vendor .dts. > > The required changes to the drivers/usb/misc/onboard_usb_dev.h are now: > > @@ -6,1 +6,1 @@ > -#define MAX_SUPPLIES 2 > +#define MAX_SUPPLIES 6 > > @@ -134,6 +134,6 @@ static const struct onboard_dev_pdata xmos_xvf3500_data = { > +static const struct onboard_dev_pdata rockchip_rk1808_data = { > + .reset_us = 25000, > + .num_supplies = 6, > + .supply_names = { "vdd", "vddlog", "vddcpu", "vdd0v8", "vcc1v8", "vccio" }, > + .is_hub = false, > +}; > > @@ -167,2 +167,2 @@ static const struct of_device_id onboard_dev_match[] = { > + { .compatible = "usb2207,1808", .data = &rockchip_rk1808_data, }, > + { .compatible = "usb2207,180a", .data = &rockchip_rk1808_data, }, > > Hoping to get your direction on this, and if this can go through as a > single patch, or should be raised as a series. I will raise a v2 of > the above if this is suitable. > > https://github.com/heitbaum/linux/commits/rock-pi-n10/ > https://github.com/heitbaum/linux/commits/rk1808/ > I took a quick look at your submission. Since it spans multiple subsystems, I'd suggest splitting it into separate series by subsystem so that maintainers can review them more easily. -- Best, Chaoyi