From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF67C77B75 for ; Tue, 18 Apr 2023 11:42:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231438AbjDRLmb (ORCPT ); Tue, 18 Apr 2023 07:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbjDRLma (ORCPT ); Tue, 18 Apr 2023 07:42:30 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90E11F0 for ; Tue, 18 Apr 2023 04:42:28 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f0a0c4e1ebso24162785e9.3 for ; Tue, 18 Apr 2023 04:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681818147; x=1684410147; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=VJhrrZF5F7exwMqfs2F/DYr7C0jvoevmcUqXzH/feoc=; b=jzOxsEqTJ/vE+PNHw+7MNs45SrWRcRdILs3o1jpljWGpevnUNsNzBP/Hne7QfimK1N 5DY3mrppe8X+jaKRQ/IbtfjvpPf0q1020JOjEX1gd+PJibeizTsiuvO1XMk66ZORWC5j lktslAieZyrktZZaXs1VOo2OOCgxt87ehbK80gCy9qUt7TMKk/oMtNdCpNzsBRcHtUHv pdIYAJyMglfkqtZfx3wGsJZhLPh/cD+9cMXyQcewLh2XXi8p4vxi1ohxB/1/S2ROicgZ L0tbdVXl1JS4tDWSNKnrMrEgWR+inwerTf5sMqNXCyLiSgJyyWx9sNlODMPpzC76QPwC a4zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681818147; x=1684410147; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VJhrrZF5F7exwMqfs2F/DYr7C0jvoevmcUqXzH/feoc=; b=YAe4NuefHR12fdinaV8M1QiBjwbW3Hae1cNQ5K1QoOm1fcPtPGWownxnRpT855qtsX vD0GQP6cna88owsXIRk1BAQmrhtXTYE5zLtuZrSRPjDZPJwPVr9I/QiEda9Gu8XC3IZO INsYCW+CRd05QOlF2oWOLhfhJeteQvIyjsyQrV9VPxKgHhZiOdeJFHjaWgNYofU9n9F4 k8RYPEN6zLtib1dTZxG3ujvk1pgaIiPyH1R3/2EOAAOAuaEIHVjcyyW0Yv7cAUPdu9rC R9A2fb2HnVc8TgNxM5NijaqRMXocVLm+Gd1mTg9vaJTbXTOv64WDC78bVP6R9JikmzhA OFng== X-Gm-Message-State: AAQBX9eZGAkRYdLdgqn6E+G/ZoUhpPhSjsRb75E9PxLQfoxpQIWIXANW zv5TYPlgLY+8D5pfS13gpfm3lg== X-Google-Smtp-Source: AKy350aDCnbeQs57GbmYsqxCTQZFjV3+gfLDfWNsHSqoL5o8sOpUjfnH5UipDVxMtKi6RxmnWS+aFA== X-Received: by 2002:a5d:698e:0:b0:2d2:f3e3:115d with SMTP id g14-20020a5d698e000000b002d2f3e3115dmr1702788wru.59.1681818146993; Tue, 18 Apr 2023 04:42:26 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:7a02:f867:7c56:79a0? ([2a01:e0a:982:cbb0:7a02:f867:7c56:79a0]) by smtp.gmail.com with ESMTPSA id h12-20020adffa8c000000b002d322b9a7f5sm12934813wrr.88.2023.04.18.04.42.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 04:42:26 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 13:42:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v2 2/5] usb: dwc2: support dwc2 IP for Amlogic A1 SoC family Content-Language: en-US To: Dmitry Rokosov , gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, mturquette@baylibre.com, vkoul@kernel.org, kishon@kernel.org, hminas@synopsys.com, Thinh.Nguyen@synopsys.com Cc: yue.wang@amlogic.com, hanjie.lin@amlogic.com, kernel@sberdevices.ru, rockosov@gmail.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org References: <20230418111612.19479-1-ddrokosov@sberdevices.ru> <20230418111612.19479-3-ddrokosov@sberdevices.ru> Organization: Linaro Developer Services In-Reply-To: <20230418111612.19479-3-ddrokosov@sberdevices.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 18/04/2023 13:16, Dmitry Rokosov wrote: > The Amlogic A1 uses dwc2 Synopsys IP as its USB peripheral (gadget) > endpoint, with different DWC2 parameters when compared to previous > Amlogic SoCs. > > Signed-off-by: Dmitry Rokosov > --- > drivers/usb/dwc2/params.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c > index 9ed9fd956940..098fbfc774ab 100644 > --- a/drivers/usb/dwc2/params.c > +++ b/drivers/usb/dwc2/params.c > @@ -161,6 +161,25 @@ static void dwc2_set_amlogic_g12a_params(struct dwc2_hsotg *hsotg) > p->hird_threshold_en = false; > } > > +static void dwc2_set_amlogic_a1_params(struct dwc2_hsotg *hsotg) > +{ > + struct dwc2_core_params *p = &hsotg->params; > + > + p->otg_caps.hnp_support = false; > + p->otg_caps.srp_support = false; > + p->speed = DWC2_SPEED_PARAM_HIGH; > + p->host_rx_fifo_size = 192; > + p->host_nperio_tx_fifo_size = 128; > + p->host_perio_tx_fifo_size = 128; > + p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI; > + p->phy_utmi_width = 8; > + p->ahbcfg = GAHBCFG_HBSTLEN_INCR8 << GAHBCFG_HBSTLEN_SHIFT; > + p->lpm = false; > + p->lpm_clock_gating = false; > + p->besl = false; > + p->hird_threshold_en = false; > +} > + > static void dwc2_set_amcc_params(struct dwc2_hsotg *hsotg) > { > struct dwc2_core_params *p = &hsotg->params; > @@ -258,6 +277,8 @@ const struct of_device_id dwc2_of_match_table[] = { > .data = dwc2_set_amlogic_params }, > { .compatible = "amlogic,meson-g12a-usb", > .data = dwc2_set_amlogic_g12a_params }, > + { .compatible = "amlogic,meson-a1-usb", > + .data = dwc2_set_amlogic_a1_params }, > { .compatible = "amcc,dwc-otg", .data = dwc2_set_amcc_params }, > { .compatible = "apm,apm82181-dwc-otg", .data = dwc2_set_amcc_params }, > { .compatible = "st,stm32f4x9-fsotg", Reviewed-by: Neil Armstrong