Linux USB
 help / color / mirror / Atom feed
From: kaf@nwlink.com
To: Neill Kapron <nkapron@google.com>
Cc: gregkh@linuxfoundation.org, pavel.hofman@ivitera.com,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_uac2: prevent invalid bInterval auto-selection
Date: Mon, 16 Nov 2026 12:58:57 -0800	[thread overview]
Message-ID: <e7a09da6d72d3d03a025adcab089c4b6@nwlink.com> (raw)
In-Reply-To: <179485828707.2938203.11219663125374064721.b4-review@b4>

On 2026-11-16 11:44, Neill Kapron wrote:
>> When p_hs_bint or c_hs_bint is 0, the driver selects the largest
>> bInterval from 4 down to 1 for which the required bandwidth fits the
>> maximum packet size. The original implementation intends to keep
>> bInterval at 1 when required bandwidth exceeds the single-packet 
>> maximum,
>> but the search loop instead decrements bInterval to 0 in that case.
>> 
>> A bInterval of 0 is invalid for an isochronous endpoint. A Linux host
>> reports it and substitutes a default:
>> 
>>   usb 3-8: ... endpoint 0x1 has an invalid bInterval 0, changing to 7
>> 
>> Stop the search at bInterval=1. Maintain existing clamping of
>> wMaxPacketSize and warning about possible data loss when the required
>> bandwidth cannot be accommodated.
>> 
>> Fixes: 355a05dc8367 ("usb: gadget: f_uac2: Optionally determine 
>> bInterval for HS and SS")
> 
> The change looks good to me but you're missing Cc: 
> stable@vger.kernel.org
> 
> Reviewed-by: Neill Kapron <nkapron@google.com>

Thanks Neill. I'll make sure to include the stable Cc on applicable 
fixes going forward.
Could I ask that you add the trailer when applying the patch?

Cc: stable@vger.kernel.org

Thanks,
Kyle Farrell

      reply	other threads:[~2026-11-16 20:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 22:28 [PATCH] usb: gadget: f_uac2: prevent invalid bInterval auto-selection Kyle Farrell
2026-10-28 22:31 ` sashiko-bot
2026-11-16 19:44 ` Neill Kapron
2026-11-16 20:58   ` kaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7a09da6d72d3d03a025adcab089c4b6@nwlink.com \
    --to=kaf@nwlink.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nkapron@google.com \
    --cc=pavel.hofman@ivitera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox