From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akash Kumar <quic_akakum@quicinc.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jack Pham <quic_jackp@quicinc.com>,
kernel@oss.qualcomm.com, Wesley Cheng <quic_wcheng@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vijayavardhan Vennapusa <quic_vvreddy@quicinc.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/18] usb: dwc3: Reserve Higher Bandwidth for HS Periodic EPs
Date: Mon, 10 Feb 2025 09:19:53 +0100 [thread overview]
Message-ID: <e8eeb6ea-b472-4f0a-a63d-5faa8f152de2@kernel.org> (raw)
In-Reply-To: <20250206111543.17392-2-quic_akakum@quicinc.com>
On 06/02/2025 12:15, Akash Kumar wrote:
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index dfa1b5fe48dc..7e55c234e4e5 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1461,6 +1461,14 @@ static int dwc3_core_init(struct dwc3 *dwc)
> dwc3_writel(dwc->regs, DWC3_GUCTL1, reg);
> }
>
> + if (dwc->revision >= DWC3_REVISION_250A) {
> + if (dwc->dwc3_guctl_resbwhseps_quirk) {
> + reg = dwc3_readl(dwc->regs, DWC3_GUCTL);
> + reg |= DWC3_GUCTL_RESBWHSEPS;
> + dwc3_writel(dwc->regs, DWC3_GUCTL, reg);
> + }
> + }
> +
> dwc3_config_threshold(dwc);
>
> /*
> @@ -1818,6 +1826,9 @@ static void dwc3_get_properties(struct dwc3 *dwc)
> dwc->dis_split_quirk = device_property_read_bool(dev,
> "snps,dis-split-quirk");
>
> + dwc->dwc3_guctl_resbwhseps_quirk = device_property_read_bool(dev,
> + "snps,dwc3_guctl_resbwhseps_quirk");
NAK, undocumented ABI, not even bothering to follow standard DTS coding
style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-10 8:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 11:15 [PATCH 00/18] Reserve high bandwidth for HS isoc eps Akash Kumar
2025-02-06 11:15 ` [PATCH 01/18] usb: dwc3: Reserve Higher Bandwidth for HS Periodic EPs Akash Kumar
2025-02-06 17:49 ` Konrad Dybcio
2025-02-10 8:16 ` AKASH KUMAR
2025-02-10 8:19 ` Krzysztof Kozlowski [this message]
2025-02-06 11:15 ` [PATCH 02/18] arm64: dts: qcom: sa8775p: Enable high bandwidth for hs isoc eps Akash Kumar
2025-02-06 11:15 ` [PATCH 03/18] arm64: dts: qcom: sm8350: " Akash Kumar
2025-02-06 11:15 ` [PATCH 04/18] arm64: dts: qcom: sm8450: " Akash Kumar
2025-02-06 11:15 ` [PATCH 05/18] arm64: dts: qcom: sm8150: " Akash Kumar
2025-02-06 11:15 ` [PATCH 06/18] arm64: dts: qcom: sm6125: " Akash Kumar
2025-02-06 11:15 ` [PATCH 07/18] arm64: dts: qcom: sm8250: " Akash Kumar
2025-02-06 11:15 ` [PATCH 08/18] arm64: dts: qcom: sm6350: " Akash Kumar
2025-02-06 11:15 ` [PATCH 09/18] arm64: dts: qcom: sc7280: " Akash Kumar
2025-02-06 11:15 ` [PATCH 10/18] arm64: dts: qcom: sdm630: " Akash Kumar
2025-02-06 11:15 ` [PATCH 11/18] arm64: dts: qcom: sdm845: " Akash Kumar
2025-02-06 11:15 ` [PATCH 12/18] arm64: dts: qcom: sdx75: " Akash Kumar
2025-02-06 11:15 ` [PATCH 13/18] arm64: dts: qcom: qcs404: " Akash Kumar
2025-02-06 11:15 ` [PATCH 14/18] arm64: dts: qcom: sc7180: " Akash Kumar
2025-02-06 11:15 ` [PATCH 15/18] arm64: dts: qcom: x1e80100: " Akash Kumar
2025-02-06 11:15 ` [PATCH 16/18] arm64: dts: qcom: " Akash Kumar
2025-02-06 11:15 ` [PATCH 17/18] arm64: dts: qcom: sc8280xp: " Akash Kumar
2025-02-06 11:15 ` [PATCH 18/18] arm64: dts: qcom: sc8180x: " Akash Kumar
2025-02-07 15:21 ` [PATCH 00/18] Reserve high bandwidth for HS " Rob Herring (Arm)
2025-02-10 8:22 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8eeb6ea-b472-4f0a-a63d-5faa8f152de2@kernel.org \
--to=krzk@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_akakum@quicinc.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_vvreddy@quicinc.com \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox